Skip to content

Rollup PR: Uses one PR to test the other #8669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions TESTS/mbed_platform/stats_sys/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,46 @@ void test_sys_info()
TEST_ASSERT_EQUAL(GCC_ARM, stats.compiler_id);
#endif
TEST_ASSERT_NOT_EQUAL(0, stats.compiler_version);

// RAM / ROM sizes should not be zero and should match the define
TEST_ASSERT_NOT_EQUAL(0, stats.ram_size[0]);
TEST_ASSERT_NOT_EQUAL(0, stats.rom_size[0]);

TEST_ASSERT_EQUAL(MBED_RAM_SIZE, stats.ram_size[0]);
TEST_ASSERT_EQUAL(MBED_ROM_SIZE, stats.rom_size[0]);
TEST_ASSERT_EQUAL(MBED_RAM_START, stats.ram_start[0]);
TEST_ASSERT_EQUAL(MBED_ROM_START, stats.rom_start[0]);

#if defined(MBED_RAM1_START) && defined(MBED_RAM1_SIZE)
TEST_ASSERT_NOT_EQUAL(0, stats.ram_size[1]);
TEST_ASSERT_EQUAL(MBED_RAM1_SIZE, stats.ram_size[1]);
TEST_ASSERT_EQUAL(MBED_RAM1_START, stats.ram_start[1]);
#endif
#if defined(MBED_RAM2_START) && defined(MBED_RAM2_SIZE)
TEST_ASSERT_NOT_EQUAL(0, stats.ram_size[2]);
TEST_ASSERT_EQUAL(MBED_RAM2_SIZE, stats.ram_size[2]);
TEST_ASSERT_EQUAL(MBED_RAM2_START, stats.ram_start[2]);
#endif
#if defined(MBED_RAM3_START) && defined(MBED_RAM3_SIZE)
TEST_ASSERT_NOT_EQUAL(0, stats.ram_size[3]);
TEST_ASSERT_EQUAL(MBED_RAM3_SIZE, stats.ram_size[3]);
TEST_ASSERT_EQUAL(MBED_RAM3_START, stats.ram_start[3]);
#endif
#if defined(MBED_ROM1_START) && defined(MBED_ROM1_SIZE)
TEST_ASSERT_NOT_EQUAL(0, stats.rom_size[1]);
TEST_ASSERT_EQUAL(MBED_ROM1_SIZE, stats.rom_size[1]);
TEST_ASSERT_EQUAL(MBED_ROM1_START, stats.rom_start[1]);
#endif
#if defined(MBED_ROM2_START) && defined(MBED_ROM2_SIZE)
TEST_ASSERT_NOT_EQUAL(0, stats.rom_size[2]);
TEST_ASSERT_EQUAL(MBED_ROM2_SIZE, stats.rom_size[2]);
TEST_ASSERT_EQUAL(MBED_ROM2_START, stats.rom_start[2]);
#endif
#if defined(MBED_ROM3_START) && defined(MBED_ROM3_SIZE)
TEST_ASSERT_NOT_EQUAL(0, stats.rom_size[3]);
TEST_ASSERT_EQUAL(MBED_ROM3_SIZE, stats.rom_size[3]);
TEST_ASSERT_EQUAL(MBED_ROM3_START, stats.rom_start[3]);
#endif
}

Case cases[] = {
Expand Down
29 changes: 29 additions & 0 deletions platform/mbed_stats.c
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,35 @@ void mbed_stats_sys_get(mbed_stats_sys_t *stats)

#if defined(MBED_SYS_STATS_ENABLED)
stats->os_version = MBED_VERSION;
stats->ram_start[0] = MBED_RAM_START;
stats->ram_size[0] = MBED_RAM_SIZE;
stats->rom_start[0] = MBED_ROM_START;
stats->rom_size[0] = MBED_ROM_SIZE;
#if defined(MBED_RAM1_START) && defined(MBED_RAM1_SIZE)
stats->ram_start[1] = MBED_RAM1_START;
stats->ram_size[1] = MBED_RAM1_SIZE;
#endif
#if defined(MBED_RAM2_START) && defined(MBED_RAM2_SIZE)
stats->ram_start[2] = MBED_RAM2_START;
stats->ram_size[2] = MBED_RAM2_SIZE;
#endif
#if defined(MBED_RAM3_START) && defined(MBED_RAM3_SIZE)
stats->ram_start[3] = MBED_RAM3_START;
stats->ram_size[3] = MBED_RAM3_SIZE;
#endif
#if defined(MBED_ROM1_START) && defined(MBED_ROM1_SIZE)
stats->rom_start[1] = MBED_ROM1_START;
stats->rom_size[1] = MBED_ROM1_SIZE;
#endif
#if defined(MBED_ROM2_START) && defined(MBED_ROM2_SIZE)
stats->rom_start[2] = MBED_ROM2_START;
stats->rom_size[2] = MBED_ROM2_SIZE;
#endif
#if defined(MBED_ROM3_START) && defined(MBED_ROM3_SIZE)
stats->rom_start[3] = MBED_ROM3_START;
stats->rom_size[3] = MBED_ROM3_SIZE;
#endif

#if defined(__CORTEX_M)
stats->cpu_id = SCB->CPUID;
#endif
Expand Down
7 changes: 7 additions & 0 deletions platform/mbed_stats.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ extern "C" {
#define MBED_THREAD_STATS_ENABLED 1
#endif

/** Maximum memory regions reported by mbed-os memory statistics */
#define MBED_MAX_MEM_REGIONS 4

/**
* struct mbed_stats_heap_t definition
*/
Expand Down Expand Up @@ -144,6 +147,10 @@ typedef struct {
uint32_t cpu_id; /**< CPUID register data (Cortex-M only supported) */
mbed_compiler_id_t compiler_id; /**< Compiler ID \ref mbed_compiler_id_t */
uint32_t compiler_version; /**< Compiler version */
uint32_t ram_start[MBED_MAX_MEM_REGIONS];/**< Start addresses of all internal RAM memories */
uint32_t ram_size[MBED_MAX_MEM_REGIONS];/**< Size of all internal RAM memories in target */
uint32_t rom_start[MBED_MAX_MEM_REGIONS];/**< Start addresses of all internal ROM memories */
uint32_t rom_size[MBED_MAX_MEM_REGIONS];/**< Size of all internal ROM memories in target */
} mbed_stats_sys_t;

/**
Expand Down
69 changes: 52 additions & 17 deletions tools/config/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@
"ETHERNET_HOST",
]

# List of all possible ram memories that can be available for a target
RAM_ALL_MEMORIES = ['IRAM1', 'IRAM2', 'IRAM3', 'IRAM4', 'SRAM_OC', \
'SRAM_ITC', 'SRAM_DTC', 'SRAM_UPPER', 'SRAM_LOWER']

# List of all possible rom memories that can be available for a target
ROM_ALL_MEMORIES = ['IROM1', 'PROGRAM_FLASH', 'IROM2']

# Base class for all configuration exceptions
class ConfigException(Exception):
"""Config system only exception. Makes it easier to distinguish config
Expand Down Expand Up @@ -610,24 +617,50 @@ def _get_mem_specs(self, memories, cmsis_part, exception_text):
continue
raise ConfigException(exception_text)

@property
def rom(self):
"""Get rom information as a pair of start_addr, size"""
def get_all_active_memories(self, memory_list):
"""Get information of all available rom/ram memories in the form of dictionary
{Memory: [start_addr, size]}. Takes in the argument, a list of all available
regions within the ram/rom memory"""
# Override rom_start/rom_size
#
# This is usually done for a target which:
# 1. Doesn't support CMSIS pack, or
# 2. Supports TrustZone and user needs to change its flash partition

available_memories = {}
# Counter to keep track of ROM/RAM memories supported by target
active_memory_counter = 0
# Find which memory we are dealing with, RAM/ROM
active_memory = 'RAM' if any('RAM' in mem_list for mem_list in memory_list) else 'ROM'
cmsis_part = self._get_cmsis_part()
rom_start, rom_size = self._get_mem_specs(
["IROM1", "PROGRAM_FLASH"],
cmsis_part,
"Not enough information in CMSIS packs to build a bootloader "
"project"
)
rom_start = int(getattr(self.target, "mbed_rom_start", False) or rom_start, 0)
rom_size = int(getattr(self.target, "mbed_rom_size", False) or rom_size, 0)
return (rom_start, rom_size)
present_memories = set(cmsis_part['memory'].keys())
valid_memories = set(memory_list).intersection(present_memories)

for memory in valid_memories:
mem_start, mem_size = self._get_mem_specs(
[memory],
cmsis_part,
"Not enough information in CMSIS packs to build a bootloader "
"project"
)
if memory=='IROM1' or memory=='PROGRAM_FLASH':
mem_start = getattr(self.target, "mbed_rom_start", False) or mem_start
mem_size = getattr(self.target, "mbed_rom_size", False) or mem_size
memory = 'ROM'
elif (memory == 'IRAM1' or memory == 'SRAM_OC' or \
memory == 'SRAM_UPPER') and (not self.has_ram_regions):
mem_start = getattr(self.target, "mbed_ram_start", False) or mem_start
mem_size = getattr(self.target, "mbed_ram_size", False) or mem_size
memory = 'RAM'
else:
active_memory_counter += 1
memory = active_memory + str(active_memory_counter)

mem_start = int(mem_start, 0)
mem_size = int(mem_size, 0)
available_memories[memory] = [mem_start, mem_size]

return available_memories

@property
def ram_regions(self):
Expand All @@ -653,13 +686,13 @@ def regions(self):
if ((self.target.bootloader_img or self.target.restrict_size) and
(self.target.mbed_app_start or self.target.mbed_app_size)):
raise ConfigException(
"target.bootloader_img and target.restirct_size are "
"target.bootloader_img and target.restrict_size are "
"incompatible with target.mbed_app_start and "
"target.mbed_app_size")
if self.target.bootloader_img or self.target.restrict_size:
return self._generate_bootloader_build(*self.rom)
return self._generate_bootloader_build(self.get_all_active_memories(ROM_ALL_MEMORIES))
else:
return self._generate_linker_overrides(*self.rom)
return self._generate_linker_overrides(self.get_all_active_memories(ROM_ALL_MEMORIES))

@staticmethod
def header_member_size(member):
Expand Down Expand Up @@ -696,7 +729,8 @@ def _assign_new_offset(rom_start, start, new_offset, region_name):
"Can not place % region inside previous region" % region_name)
return newstart

def _generate_bootloader_build(self, rom_start, rom_size):
def _generate_bootloader_build(self, rom_memories):
rom_start, rom_size = rom_memories.get('ROM')
start = rom_start
rom_end = rom_start + rom_size
if self.target.bootloader_img:
Expand Down Expand Up @@ -780,7 +814,8 @@ def report(self):
return {'app_config': self.app_config_location,
'library_configs': map(relpath, self.processed_configs.keys())}

def _generate_linker_overrides(self, rom_start, rom_size):
def _generate_linker_overrides(self, rom_memories):
rom_start, rom_size = rom_memories.get('ROM')
if self.target.mbed_app_start is not None:
start = int(self.target.mbed_app_start, 0)
else:
Expand Down
30 changes: 23 additions & 7 deletions tools/toolchains/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
from ..notifier.term import TerminalNotifier
from ..resources import FileType
from ..memap import MemapParser
from ..config import ConfigException
from ..config import (ConfigException, RAM_ALL_MEMORIES, ROM_ALL_MEMORIES)


#Disables multiprocessing if set to higher number than the host machine CPUs
Expand Down Expand Up @@ -738,13 +738,29 @@ def add_regions(self):
", ".join(r.name for r in regions)
))
self._add_all_regions(regions, "MBED_RAM")

Region = namedtuple("Region", "name start size")

try:
# Add all available ROM regions to build profile
rom_available_regions = self.config.get_all_active_memories(ROM_ALL_MEMORIES)
for key, value in rom_available_regions.items():
rom_start, rom_size = value
self._add_defines_from_region(
Region("MBED_" + key, rom_start, rom_size),
suffixes=["_START", "_SIZE"]
)
except ConfigException:
pass
try:
rom_start, rom_size = self.config.rom
Region = namedtuple("Region", "name start size")
self._add_defines_from_region(
Region("MBED_ROM", rom_start, rom_size),
suffixes=["_START", "_SIZE"]
)
# Add all available RAM regions to build profile
ram_available_regions = self.config.get_all_active_memories(RAM_ALL_MEMORIES)
for key, value in ram_available_regions.items():
ram_start, ram_size = value
self._add_defines_from_region(
Region("MBED_" + key, ram_start, ram_size),
suffixes=["_START", "_SIZE"]
)
except ConfigException:
pass

Expand Down