Remove protected member functions and protected attributes from rendering #8670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepikabhavnani
force-pushed
the
doxy_fix_protected
branch
2 times, most recently
from
607225b to
e53c322
Compare
0xc0170
approved these changes
Nov 8, 2018
|
I've noticed this previously in PR, and seeing this is not followed in new API that I've reviewed recently. Do we have documentation capturing this rule ? @AnotherButler |
melwee01
reviewed
Nov 8, 2018
deepikabhavnani
force-pushed
the
doxy_fix_protected
branch
from
cb39c4d to
d48ff10
Compare
1. Remove protected member functions and protected attributes from rendering on docs site 2. Update BusInOut doxygen
deepikabhavnani
force-pushed
the
doxy_fix_protected
branch
from
12f92f0 to
a21a422
Compare
|
@melwee01 When you can, pelase re-review. Comment addressed. |
melwee01
approved these changes
Nov 9, 2018
|
Note: This PR is now a part of a rollup PR (#8694). No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged. If any more commits are made in this PR, this PR will remain open and have to go through CI on its own. |
|
Sits on top of 5.11 changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove protected member functions and protected attributes from rendering on docs site
Pull request type
CC @AnotherButler