-
Notifications
You must be signed in to change notification settings - Fork 3k
Feature: Add non-blocking serial break/unbreak functions #8671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can ignore the 2 referenced PRs/commits - Pasted in this PR link for future reference and have nothing to do with this PR into mbed-os |
Seems reasonable to me - obviously you need to know what you're doing, and not mix this with any output calls. Would need more work to make it work with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry, forgot to push my one comment to this. I think this is my only issue.
Current serial implementation has a send_break() command which sends a break command on the UART for a fixed amount of time. Added functions to allow users to send a break in a non-blocking fashion, as well as for a user-specified amount of time.
@kjbracey-arm Added locks and unlocks surrounding each uart break call |
/morph build |
Build : SUCCESSBuild number : 3652 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3259 |
Test : SUCCESSBuild number : 3432 |
Description
Current serial implementation has a send_break() command which sends a break command on the UART for a fixed amount of time. Fixed amount of time (in uS) is 18000000 / baud_rate. Additionally, the command is blocking.
This PR adds functions to the serial class to allow users to send a break in a non-blocking fashion, as well as for a user-specified amount of time.
Pull request type