Skip to content

TLSSocketWrapper: decouple error requirements #8687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2018
Merged

TLSSocketWrapper: decouple error requirements #8687

merged 1 commit into from
Nov 13, 2018

Conversation

kjbracey
Copy link
Contributor

@kjbracey kjbracey commented Nov 9, 2018

Description

  • Don't pull in mbedtls_strerror() if trace is not enabled.
  • Output error trace even if mbedtls_strerror() is not available.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@kjbracey kjbracey requested a review from SeppoTakalo November 9, 2018 09:50
@cmonr cmonr added rollup PR and removed rollup PR labels Nov 9, 2018
@cmonr
Copy link
Contributor

cmonr commented Nov 9, 2018

Ah. Looks like this PR needs a rebase.

@kjbracey
TLSSocketWrapper: decouple error requirements
913103c 
* Don't pull in mbedtls_strerror() if trace is not enabled.
* Output error trace even if mbedtls_strerror() is not available.
@kjbracey
Copy link
Contributor Author

Rebased. Added MBED_UNUSED attributes as I realised you might still get some warnings with mbed trace disabled.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 12, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 12, 2018

Build : SUCCESS

Build number : 3601
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8687/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 12, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Nov 12, 2018

Test : SUCCESS

Build number : 3378
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8687/3378

@mbed-ci
Copy link

mbed-ci commented Nov 12, 2018

Exporter Build : SUCCESS

Build number : 3206
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8687/

@cmonr cmonr merged commit aab3ade into ARMmbed:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kjbracey @cmonr @0xc0170 @mbed-ci @SeppoTakalo