Skip to content

NFC Eeprom erase command fails #8718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2018
Merged

NFC Eeprom erase command fails #8718

merged 3 commits into from
Nov 15, 2018

Conversation

ConradBraam
Copy link
Contributor

Description

Fix the state machine in wrapper class, IOTPAN-295.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@adbridge
Copy link
Contributor

@ConradBraam please note that we do not normally accept 'merge' commits into PRs. These tend to cause a lot of issues when trying to patch the commits to the release branch. In this instance though as we are so close to 5.11 if it fails to patch across successfully to 5.10.4 we will just bump it out.

@adbridge
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 14, 2018

Build : SUCCESS

Build number : 3621
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8718/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 14, 2018

@mbed-ci
Copy link

mbed-ci commented Nov 15, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 15, 2018

Note: This PR is now a part of a rollup PR (#8753).

In order to expedite remaining CI testing, this PR has been bundled into the above rollup PR.

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@cmonr
Copy link
Contributor

cmonr commented Nov 15, 2018

Please ignore. I derped.

@cmonr cmonr merged commit ef81f4b into ARMmbed:master Nov 15, 2018
@adbridge
Copy link
Contributor

@ConradBraam As suspected the merge commits on this PR caused havoc with the patching script so this is being bumped to 5.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants