Add support for GD32F307VG #8725

ChazJin · 2018-11-13T09:11:30Z

Description

This pull request adds support for GD32F307VG MCU and GD EMAC driver. All the tests were verified on GD32-F307VG board ("detect_code": ["1701"]).

#8713 is the old version and I have closed it. In contrast to the older version, we added the licence of the files, modified some file names, and added the GD EMAC driver files.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

targets/TARGET_GigaDevice/TARGET_GD32F30X/i2c_api.c

targets/TARGET_GigaDevice/TARGET_GD32F30X/TATGET_GD32F307VG/PinNames.h

ChazJin · 2018-11-14T11:54:40Z

The test results are as follows(WIN10, run "mbed test -t GCC_ARM/ARM/IAR -m GD32_F307VG" directly):
GD32_F307VG_ARM.txt
GD32_F307VG_GCC.txt
GD32_F307VG_IAR.txt

adbridge · 2018-11-14T14:49:33Z

@ChazJin Could you please rebase this ?

1. Mainly change TARGET_Gigadevice --> TARGET_GigaDevice 2. Add license header

Add GD32F307VG MCU information to target.json

ChazJin · 2018-11-15T09:18:01Z

@ChazJin Could you please rebase this ?

Hello @adbridge, I have rebased it and keep my own repository(https://github.com/ChazJin/mbed-os) consistent with the remote repository(https://github.com/ARMmbed/mbed-os). Would you please let me know is it the right way of doing it?

My previous tests were based on 5.10.1, and I will upload the test results based on the latest 5.10.3 library later.

adbridge · 2018-11-15T11:33:30Z

@ChazJin we seem to be getting a number of failures:

Bad Assembler file name found: ./targets/TARGET_GigaDevice/TARGET_GD32F30X/TATGET_GD32F307VG/device/TOOLCHAIN_GCC_ARM/startup_gd32f30x_cl.s
Bad Assembler file name found: ./targets/TARGET_GigaDevice/TARGET_GD32F30X/TATGET_GD32F307VG/device/TOOLCHAIN_ARM_MICRO/startup_gd32f30x_cl.s
Bad Assembler file name found: ./targets/TARGET_GigaDevice/TARGET_GD32F30X/TATGET_GD32F307VG/device/TOOLCHAIN_ARM_STD/startup_gd32f30x_cl.s
Bad Assembler file name found: ./targets/TARGET_GigaDevice/TARGET_GD32F30X/TATGET_GD32F307VG/device/TOOLCHAIN_IAR/startup_gd32f30x_cl.s

           AssertionError: Target GD32_F307VG contains invalid device_name GD32F307VG
E           assert 'GD32F307VG' in {'A31G111': {'algorithm': {'A31G11x/Flashloader/A31G11x_series_CFG.FLM': {'default': '1', 'ramsize': None, 'ramstart':...': 'A31G12x/Core/include/A31G12x_series.h'}, 'core': 'Cortex-M0', 'debug': 'A31G12x/SVD/A31G12x_series.svd', ...}, ...}
E            +  where 'GD32F307VG' = Target(name=u'GD32_F307VG', json_data={u'GD32_Target': OrderedDict([(u'inherit...rget', 2)], resolution_order_names=[u'GD32_F307VG', u'GD32_Target', u'Target']).device_name
E            +  and   {'A31G111': {'algorithm': {'A31G11x/Flashloader/A31G11x_series_CFG.FLM': {'default': '1', 'ramsize': None, 'ramstart':...': 'A31G12x/Core/include/A31G12x_series.h'}, 'core': 'Cortex-M0', 'debug': 'A31G12x/SVD/A31G12x_series.svd', ...}, ...} = <tools.arm_pack_manager.Cache instance at 0x7f88c9a3f6c8>.index

@ashok-rao can you help?

ashok-rao · 2018-11-15T12:45:16Z

Where is this "GD32_F307VG" (with the underscore) coming from? from the logs above, I see: "where 'GD32F307VG' = Target(name=u'GD32_F307VG',"

Also, there seems to be a typo TARGET_GD32F30X/TA T GET_GD32F307VG .. not entirely sure if fixing these would help?

ChazJin · 2018-11-15T13:58:36Z

@ChazJin we seem to be getting a number of failures:

Bad Assembler file name found: ./targets/TARGET_GigaDevice/TARGET_GD32F30X/TATGET_GD32F307VG/device/TOOLCHAIN_GCC_ARM/startup_gd32f30x_cl.s
Bad Assembler file name found: ./targets/TARGET_GigaDevice/TARGET_GD32F30X/TATGET_GD32F307VG/device/TOOLCHAIN_ARM_MICRO/startup_gd32f30x_cl.s
Bad Assembler file name found: ./targets/TARGET_GigaDevice/TARGET_GD32F30X/TATGET_GD32F307VG/device/TOOLCHAIN_ARM_STD/startup_gd32f30x_cl.s
Bad Assembler file name found: ./targets/TARGET_GigaDevice/TARGET_GD32F30X/TATGET_GD32F307VG/device/TOOLCHAIN_IAR/startup_gd32f30x_cl.s

           AssertionError: Target GD32_F307VG contains invalid device_name GD32F307VG
E           assert 'GD32F307VG' in {'A31G111': {'algorithm': {'A31G11x/Flashloader/A31G11x_series_CFG.FLM': {'default': '1', 'ramsize': None, 'ramstart':...': 'A31G12x/Core/include/A31G12x_series.h'}, 'core': 'Cortex-M0', 'debug': 'A31G12x/SVD/A31G12x_series.svd', ...}, ...}
E            +  where 'GD32F307VG' = Target(name=u'GD32_F307VG', json_data={u'GD32_Target': OrderedDict([(u'inherit...rget', 2)], resolution_order_names=[u'GD32_F307VG', u'GD32_Target', u'Target']).device_name
E            +  and   {'A31G111': {'algorithm': {'A31G11x/Flashloader/A31G11x_series_CFG.FLM': {'default': '1', 'ramsize': None, 'ramstart':...': 'A31G12x/Core/include/A31G12x_series.h'}, 'core': 'Cortex-M0', 'debug': 'A31G12x/SVD/A31G12x_series.svd', ...}, ...} = <tools.arm_pack_manager.Cache instance at 0x7f88c9a3f6c8>.index

@ashok-rao can you help?

@adbridge Is this related to our current MCU being temporarily not in CMSIS PACK? And our engineers have modified the keil5 pack of GigaDevice MCU, which will be uploaded to the server and will take effect soon. FLM and SVD files of GigaDevice MCU will definitely be found next week at the latest.

theotherjimmy · 2018-11-15T15:12:24Z

@ChazJin The first error is that your assembly files end with .s. We require (for maximum compatibility) that they end with .S (it's a capitol instead of a small).

The second error is that your MCU is not in CMSIS Pack yet. You can remove device_name from your target in targets.json to get this in faster, and later submit a PR that adds back that value with the data from the released CMSIS Pack.

0xc0170 · 2018-12-06T12:32:51Z

CI restarted

mbed-ci · 2018-12-06T13:26:47Z

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 11
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR

ChazJin · 2018-12-06T13:39:30Z

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 11
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM

jenkins-ci/mbed-os-ci_build-ARM

jenkins-ci/mbed-os-ci_build-IAR

I'm sorry to say that we can't open these links above and the Details of jenkins-ci/build-ARM/GCC_ARM/IAR, so we can't see the specific errors. Could you please help us? @0xc0170 Thank a lot!

cmonr · 2018-12-06T15:56:25Z

@ChazJin Do you have access to this page? http://mbed-os-ci.s3-website-eu-west-1.amazonaws.com/?prefix=jenkins-ci/artifacts/8725/11/

It requires javascript (not sure why...), if that helps.

Delete GD32F450ZI and GD323103VB which are not implemented yet and add them later.

ChazJin · 2018-12-07T07:38:53Z

@cmonr Thank you for your advise and I have found the reason for the errors. The "GD32F450ZI" and "GD32E103VB" are the projects we're working on, but they're not finished yet. After I removed the information about these two targets from target.json, I think the result will be OK. The links are as follows.
http://mbed-os-ci.s3-website-eu-west-1.amazonaws.com/?prefix=jenkins-ci/artifacts/8725/11/build-ARM/PASS/GD32_F307VG/
http://mbed-os-ci.s3-website-eu-west-1.amazonaws.com/?prefix=jenkins-ci/artifacts/8725/11/build-ARM/FAIL/GD32_E103VB/
http://mbed-os-ci.s3-website-eu-west-1.amazonaws.com/?prefix=jenkins-ci/artifacts/8725/11/build-ARM/FAIL/GD32_F450ZI/

@0xc0170 Please help us to run CI test again, and I really appreciate it.

cmonr · 2018-12-11T02:12:45Z

Prioritizing RC3 PRs. Will start when able.

cmonr · 2018-12-12T03:19:17Z

CI started

mbed-ci · 2018-12-12T09:38:17Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 12
Build artifacts

cmonr · 2018-12-28T05:31:41Z

@ChazJin We're working on releasing 5.11.1, and are testing the RC now: #9208

However, this PR gave us quite a bit of trouble. When working on future PRs, please make sure that commits from patch resolutions are not in the commit history. Lines like this 5a15f81#diff-e9bd16efde5b7f92c0dcd845c5cf3619L352 caused us to manually apply this PR to the release.

ChazJin · 2018-12-28T07:40:01Z

We are VERY SORRY to have caused you so much trouble. This is our first PR and we will surely pay attention to it in the future PRs. Once again we would like to apologize for it. @cmonr

ChazJin mentioned this pull request Nov 13, 2018

Add support for GD32F307VG #8722

Closed

0xc0170 changed the title ~~Re add support for GD32F307VG~~ Add support for GD32F307VG Nov 13, 2018

0xc0170 added the needs: review label Nov 13, 2018

0xc0170 requested review from ashok-rao and a team November 13, 2018 10:07

ashok-rao reviewed Nov 13, 2018

View reviewed changes

targets/TARGET_GigaDevice/TARGET_GD32F30X/i2c_api.c Outdated Show resolved Hide resolved

ashok-rao reviewed Nov 13, 2018

View reviewed changes

targets/TARGET_GigaDevice/TARGET_GD32F30X/TATGET_GD32F307VG/PinNames.h Outdated Show resolved Hide resolved

adbridge added the scope: new-target label Nov 14, 2018

adbridge added needs: work and removed needs: review labels Nov 14, 2018

ChazJin and others added 7 commits November 15, 2018 16:01

Add GD32F307VG

6403b9c

Re add target support for GD32F307VG

9752a9b

1. Mainly change TARGET_Gigadevice --> TARGET_GigaDevice 2. Add license header

Delete added information (GD32F307VG)

55a4261

Add EMAC driver for GD32_F307VG

eb39c48

Update licence

cc94bfa

Update licence

49b25c9

Update licence

42bffe2

ChazJin force-pushed the master branch from caef34b to 42bffe2 Compare November 15, 2018 08:20

ChazJin added 2 commits November 15, 2018 16:55

Add support for GD32F307VG

0d4bb5c

Add GD32F307VG MCU information to target.json

Delete a button definition

d44ef27

ChazJin added 3 commits November 16, 2018 11:07

Add it to replace startup_gd32f30x_cl.s

c566757

Delete startup_gd32f30x_cl.s

369eec8

Add it to replace startup_gd32f30x_cl.s

7e480f0

0xc0170 added needs: CI and removed needs: work labels Dec 6, 2018

cmonr added needs: work and removed needs: CI labels Dec 6, 2018

Delete GD32F450ZI and GD323103VB which are not implemented

ca46d12

Delete GD32F450ZI and GD323103VB which are not implemented yet and add them later.

ChazJin closed this Dec 7, 2018

studavekar removed the needs: work label Dec 7, 2018

ChazJin reopened this Dec 7, 2018

Style Format for GD32F30x standard peripheral files

6ac625d

cmonr added needs: review needs: work needs: CI and removed needs: review needs: work labels Dec 10, 2018

0xc0170 added ready for merge and removed needs: CI labels Dec 12, 2018

0xc0170 merged commit c387fec into ARMmbed:master Dec 12, 2018

0xc0170 removed the ready for merge label Dec 12, 2018

cmonr added release-version: 5.11.1 and removed release-version: 5.11.1 labels Dec 28, 2018

Add support for GD32F307VG #8725

Add support for GD32F307VG #8725

Uh oh!

Conversation

ChazJin commented Nov 13, 2018

Description

Pull request type

Uh oh!

Uh oh!

Uh oh!

ChazJin commented Nov 14, 2018

Uh oh!

adbridge commented Nov 14, 2018

Uh oh!

ChazJin commented Nov 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adbridge commented Nov 15, 2018

Uh oh!

ashok-rao commented Nov 15, 2018

Uh oh!

ChazJin commented Nov 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theotherjimmy commented Nov 15, 2018

Uh oh!

0xc0170 commented Dec 6, 2018

Uh oh!

mbed-ci commented Dec 6, 2018

Test run: FAILED

Uh oh!

ChazJin commented Dec 6, 2018

Test run: FAILED

Uh oh!

cmonr commented Dec 6, 2018

Uh oh!

ChazJin commented Dec 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Dec 11, 2018

Uh oh!

cmonr commented Dec 12, 2018

Uh oh!

mbed-ci commented Dec 12, 2018

Test run: SUCCESS

Uh oh!

cmonr commented Dec 28, 2018

Uh oh!

ChazJin commented Dec 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ChazJin commented Nov 15, 2018 •

edited

Loading

ChazJin commented Nov 15, 2018 •

edited

Loading

ChazJin commented Dec 7, 2018 •

edited

Loading

ChazJin commented Dec 28, 2018 •

edited

Loading