Skip to content

LoRaWANTimer UT fixed #8727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2018
Merged

LoRaWANTimer UT fixed #8727

merged 1 commit into from
Nov 15, 2018

Conversation

AnttiKauppila
Copy link

Description

LoRaWAN_Timer unittest was segfaulting, this is fixed now

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

@AnttiKauppila
Copy link
Author

@TeemuKultala please review

Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will LoRaWAN unit tess no longer have debug statements? Or did it never have them to begin with?

@AnttiKauppila
Copy link
Author

The change is only for LoRaWANTimer class, not the whole LoRaWAN test set

@adbridge
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 14, 2018

Build : SUCCESS

Build number : 3627
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8727/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 15, 2018

@cmonr
Copy link
Contributor

cmonr commented Nov 15, 2018

Export nodes got stuck.

Will relaunch when able.

@mbed-ci
Copy link

mbed-ci commented Nov 15, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 15, 2018

Note: This PR is now a part of a rollup PR (#8753).

In order to expedite remaining CI testing, this PR has been bundled into the above rollup PR.

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@cmonr
Copy link
Contributor

cmonr commented Nov 15, 2018

Please ignore. I derped.

@cmonr cmonr merged commit 0777771 into ARMmbed:master Nov 15, 2018
@AnttiKauppila AnttiKauppila deleted the lora_ut_fix branch November 16, 2018 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants