L3IP Interface Implementation #8739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cmonr merged 1 commit into ARMmbed:master from tymoteuszblochmobica:master

Dec 20, 2018

Contributor

tymoteuszblochmobica commented Nov 14, 2018

Description

LWIP L3IP interface initial implementation

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Contributor Author

tymoteuszblochmobica commented Nov 14, 2018

@SeppoTakalo please review
@mikaleppanen please review
@kjbracey-arm please review
@mirelachirica please review
@AriParkkila please review

0xc0170 requested a review from a team

November 14, 2018 13:20

0xc0170 added the needs: review label

Contributor

0xc0170 commented Nov 14, 2018

@tymoteuszblochmobica Please review Ci failures (travis)

tymoteuszblochmobica force-pushed the master branch 4 times, most recently from b933fc6 to d512867 Compare

November 14, 2018 16:07

SeppoTakalo approved these changes

View reviewed changes

Contributor

SeppoTakalo commented Nov 16, 2018

@0xc0170 Can be tested now.

Contributor

0xc0170 commented Nov 16, 2018

travis-ci/astyle — Passed, 66 files (+8 files)

@tymoteuszblochmobica Please fix these (I would recommend rebasing on top of the latest master, this would be an error in Travis) and we will run CI asap

0xc0170 requested changes

View reviewed changes

Contributor

0xc0170 left a comment

Apply to all new files added here

features/lwipstack/LWIPInterfaceL3IP.cpp Outdated

		@@ -0,0 +1,167 @@
		/* mbed Microcontroller Library
		* Copyright (c) 2016 ARM Limited

Contributor

0xc0170 Nov 16, 2018

Add SPDX identifier, also fix the year (2018)

Contributor Author

tymoteuszblochmobica Nov 20, 2018

done

tymoteuszblochmobica force-pushed the master branch 7 times, most recently from 1f98fea to 00adc55 Compare

November 20, 2018 10:20

0xc0170 approved these changes

View reviewed changes

0xc0170 requested review from mikaleppanen, kjbracey and AriParkkila

November 20, 2018 10:53

mikaleppanen suggested changes

View reviewed changes

features/lwipstack/lwipopts.h Outdated

    
            @@ -331,6 +331,8 @@
          
              #define LWIP_ETHERNET               0

              #endif // MBED_CONF_LWIP_ETHERNET_ENABLED

              #define LWIP_L3IP   				1

mikaleppanen Nov 20, 2018

I think this needs similar configuration option as ethernet to mbed_lib.json. And should be disabled by default.

Contributor Author

tymoteuszblochmobica Nov 20, 2018

changed

0xc0170 added needs: work and removed needs: review labels

tymoteuszblochmobica force-pushed the master branch 2 times, most recently from ffd3604 to df16b4a Compare

November 20, 2018 13:16

mikaleppanen approved these changes

View reviewed changes

0xc0170 added the needs: review label

0xc0170 removed the needs: work label

0xc0170 requested review from AnotherButler and melwee01

November 21, 2018 11:51

Contributor

0xc0170 commented Nov 21, 2018

@AnotherButler @melwee01 Please review docs for the new functionality

tymoteuszblochmobica force-pushed the master branch from df16b4a to 703dea3 Compare

November 23, 2018 12:23

Contributor

0xc0170 commented Nov 26, 2018

@AnotherButler @melwee01 Please review docs for the new functionality

Please review. We will start tests now.

@SeppoTakalo @tymoteuszblochmobica 5.11 target or ?

Contributor

SeppoTakalo commented Nov 26, 2018

Not 5.11 target.. can enter the master now, but will be functional only when first L3 driver published.
So probably 5.12

0xc0170 added the release-version: 5.12.0-rc1 label

tymoteuszblochmobica force-pushed the master branch from 703dea3 to 64e2f16 Compare

December 4, 2018 11:10

Contributor

0xc0170 commented Dec 13, 2018

I started CI to check if this fails as previously did, meanwhile waiting for reviewers to complete their reviews

Contributor

melwee01 commented Dec 13, 2018

I'll take a look.

melwee01 reviewed

View reviewed changes

Contributor

melwee01 left a comment

Have looked at first header file, but will get to second one after lunch.

Contributor

0xc0170 commented Dec 13, 2018

Have looked at first header file, but will get to second one after lunch.

Ok waiting with CI. First run failed due to EOF exception, will need restart anyway

Contributor

cmonr commented Dec 14, 2018

@melwee01 Doing alright?

Contributor

0xc0170 commented Dec 14, 2018

@AnotherButler Please complete the docs review.

AnotherButler reviewed

View reviewed changes

Contributor

AnotherButler left a comment

Please make my requested changes and then feel free to merge

features/netsocket/cellular/cellular_driver_l3ip.h Outdated

    
                  /** Remove device from an IPV6 multicast group

                  *

                  * @param address  An IPV6 multicast group  address

Contributor

AnotherButler Dec 14, 2018

Please do a search for "group address", and delete the extra space each time.

features/netsocket/cellular/cellular_driver_l3ip.h Outdated

    
                  virtual bool power_up();

                  /**

                   * Deinitializes the HW

Contributor

AnotherButler Dec 14, 2018

Please spell out "hardware" each time for consistency.

features/netsocket/cellular/cellular_driver_l3ip.h Outdated

    
                   * That can not be called from an interrupt context.

                   *

                   * @param buf  Packet to be send

                   * @return     True if the packet was send successfully, False otherwise

Contributor

AnotherButler Dec 14, 2018

was sent, false otherwise

features/netsocket/cellular/cellular_driver_l3ip.h Outdated

    
                   *

                   * That can not be called from an interrupt context.

                   *

                   * @param buf  Packet to be send

Contributor

AnotherButler Dec 14, 2018

to be sent

features/netsocket/cellular/cellular_driver_l3ip.h Outdated

    
                  /**

                   * Sends the packet over the link

                   *

                   * That can not be called from an interrupt context.

Contributor

AnotherButler Dec 14, 2018

cannot

features/netsocket/L3IP.h Outdated

    
                   * That can not be called from an interrupt context.

                   *

                   * @param buf  Packet to be send

                   * @return     True if the packet was send successfully, False otherwise

Contributor

AnotherButler Dec 14, 2018

was sent successfully, false otherwise

features/netsocket/L3IP.h Outdated

    
                  /**

                   * Sends the packet over the link

                   *

                   * That can not be called from an interrupt context.

Contributor

AnotherButler Dec 14, 2018

cannot

features/netsocket/L3IP.h Outdated

    
                  typedef mbed::Callback<void (net_stack_mem_buf_t *buf)> l3ip_link_input_cb_t;

                  /**

                   * Callback to be register with l3ip interface and to be called for link status changes

Contributor

AnotherButler Dec 14, 2018

Callback to be registered with L3IP interface

features/netsocket/L3IP.h Outdated

    
                  static L3IP &get_default_instance();

                  /**

                   * Callback to be register with l3ip interface and to be called for received packets

Contributor

AnotherButler Dec 14, 2018

Callback to be registered with L3IP

features/netsocket/L3IP.h Outdated

    
              /**

               * This interface should be used to abstract low level access to networking hardware

               * All operations receive a `void *` hw pointer which an l3ip device provides when

Contributor

AnotherButler Dec 14, 2018

hardware pointer, which an L3IP device

tymoteuszblochmobica force-pushed the master branch 2 times, most recently from d3cb586 to 4f34dd1 Compare

December 18, 2018 15:20


          L3IP Interface Implementation

fc88922

LWIP L3IP interface initial implementatioon

tymoteuszblochmobica force-pushed the master branch from 4f34dd1 to fc88922 Compare

December 20, 2018 14:35

cmonr added needs: CI and removed needs: review labels

Contributor

cmonr commented Dec 20, 2018

CI started

mbed-ci commented Dec 20, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 8
Build artifacts

cmonr added needs: work ready for merge and removed needs: CI needs: work labels

cmonr merged commit ac361d6 into ARMmbed:master

cmonr removed the ready for merge label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AnotherButler AnotherButler left review comments

melwee01 melwee01 left review comments

0xc0170 0xc0170 approved these changes

SeppoTakalo SeppoTakalo approved these changes

mikaleppanen mikaleppanen approved these changes

kjbracey Awaiting requested review from kjbracey

AriParkkila Awaiting requested review from AriParkkila

Labels

release-version: 5.12.0-rc1