-
Notifications
You must be signed in to change notification settings - Fork 3k
Add design document for network statistics. #8743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Submitting design documents that have been reviewed and discussed in internal email chain. For @deepikabhavnani and @SenRamakri and @lauri-piikivi to review if I missed any details. |
This is just |
@AnotherButler - Please review |
SocketStats Class is added to collect and provide the statistics information. In this phase only socket information is collected and max sockets that can be recorded at any time are configurable through 'MBED_CONF_NSAPI_SOCKET_STATS_MAX_COUNT' Network statistics can be enabled through a macro MBED_NW_STATS_ENABLED More information on design is captured in ARMmbed#8743
@melwee01 Can you review ? |
|
||
``` | ||
typedef struct { | ||
uint32_t tick; /**< osKernelGetTick() value of when event happened, or equivalent timestamp */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be 64bit timestamp (Kernel::get_ms_count()
) or sufficient having 32 bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"or equivalent"
;)
So the implementation can do this correctly by using uint64_t
as that is what Mbed OS API gives.
If this is for external use, then what kind of delivery are we talking about? |
Didn't get that query. |
Is this for the Mbed OS docs site? If so, it needs not just some formatting changes but a full rewrite to be in accordance with the external docs standards. |
No these are internal design docs which stay in mbed-os repo. |
SocketStats Class is added to collect and provide the statistics information. In this phase only socket information is collected and max sockets that can be recorded at any time are configurable through 'MBED_CONF_NSAPI_SOCKET_STATS_MAX_COUNT' Network statistics can be enabled through a macro MBED_NW_STATS_ENABLED More information on design is captured in ARMmbed#8743
Description
Add design document for network statistics.
Pull request type