-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix cellular backward compatibility #8766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you please rebase |
f3e1eeb
to
5d8fc3d
Compare
@0xc0170 rebased |
5d8fc3d
to
b41db86
Compare
checkout failure in continuous-integration/jenkins/pr-head rebased for a new try |
b41db86
to
a3589ed
Compare
@0xc0170 can you proceed or does this need @kjbracey-arm approval? |
@0xc0170 this PR is required to get most of @ARMmbed/mbed-os-ipcore's CI jobs running. Would be good to get this in as soon as possible. |
We will trigger CI soon |
CI triggered |
@0xc0170 seems like a python failure afte some test failure: GCC_ARM-K66F | K66F | wifi | TIMEOUT | 85.04 | default |
Rerunning the memory usage job |
Restarted did not help. @ARMmbed/mbed-os-test Please review jenkins-ci/dynamic-memory-usage |
I aborted the current job, will be restarted once 8667 completes (lot of dependencies on this one) and the fix was also integrated only recently - there was a bug in dynamic memory usage scripts. |
@ARMmbed/mbed-os-test jenkins-ci/dynamic-memory-usage - still reports an error - different issue |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Exports timeout, we are investigating |
Dynamic memory and exporters restarted |
dynamic-memory-usage will be restarted once python bug in the script is fixed Restarting now exporters |
Restarted dynamic memory usage (it was disabled until the internal error is resolved). |
Fixed cellular backward compatibility by adding boolean to OnboardCellularInterface wrapper.
https://github.com/ARMmbed/mbed-os-cliapp was not compiling as it used debug flag in constructor.
@VeijoPesonen @kjbracey-arm please review.
Pull request type