Skip to content

Fix cellular backward compatibility #8766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Nov 16, 2018

Fixed cellular backward compatibility by adding boolean to OnboardCellularInterface wrapper.

https://github.com/ARMmbed/mbed-os-cliapp was not compiling as it used debug flag in constructor.

@VeijoPesonen @kjbracey-arm please review.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 16, 2018

features/netsocket/cellular/generic_modem_driver/OnboardCellularInterface.h

Can you please rebase

@jarvte jarvte force-pushed the fix_cellular_backward_com branch from f3e1eeb to 5d8fc3d Compare November 16, 2018 10:11
@jarvte
Copy link
Contributor Author

jarvte commented Nov 16, 2018

@0xc0170 rebased

@jarvte jarvte force-pushed the fix_cellular_backward_com branch from 5d8fc3d to b41db86 Compare November 16, 2018 11:11
@jarvte
Copy link
Contributor Author

jarvte commented Nov 19, 2018

checkout failure in continuous-integration/jenkins/pr-head

rebased for a new try

@jarvte jarvte force-pushed the fix_cellular_backward_com branch from b41db86 to a3589ed Compare November 19, 2018 07:04
@0xc0170 0xc0170 changed the title Fixed cellular backward compatibility. Fix cellular backward compatibility Nov 19, 2018
@jarvte
Copy link
Contributor Author

jarvte commented Nov 21, 2018

@0xc0170 can you proceed or does this need @kjbracey-arm approval?

@VeijoPesonen
Copy link
Contributor

@0xc0170 this PR is required to get most of @ARMmbed/mbed-os-ipcore's CI jobs running. Would be good to get this in as soon as possible.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2018

We will trigger CI soon

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2018

CI triggered

@jarvte
Copy link
Contributor Author

jarvte commented Nov 22, 2018

@0xc0170 seems like a python failure afte some test failure:

GCC_ARM-K66F | K66F | wifi | TIMEOUT | 85.04 | default
GCC_ARM-K66F | K66F | wifi | wifi | 0 | 1 | ERROR | 85.04

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2018

Rerunning the memory usage job

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2018

Restarted did not help.

@ARMmbed/mbed-os-test Please review jenkins-ci/dynamic-memory-usage

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2018

@0xc0170 seems like a python failure afte some test failure:

I aborted the current job, will be restarted once 8667 completes (lot of dependencies on this one) and the fix was also integrated only recently - there was a bug in dynamic memory usage scripts.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2018

@ARMmbed/mbed-os-test jenkins-ci/dynamic-memory-usage - still reports an error - different issue

@mbed-ci
Copy link

mbed-ci commented Nov 22, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 3
Build artifacts
Build logs

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 23, 2018

Exports timeout, we are investigating

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 23, 2018

Dynamic memory and exporters restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 23, 2018

dynamic-memory-usage will be restarted once python bug in the script is fixed

Restarting now exporters

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 23, 2018

Restarted dynamic memory usage (it was disabled until the internal error is resolved).

@0xc0170 0xc0170 merged commit cb6f5d6 into ARMmbed:master Nov 24, 2018
@jarvte jarvte deleted the fix_cellular_backward_com branch November 26, 2018 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants