Compatibilize ArmC6 with ArmC5-built archives #8803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description
Arm compiler 5 builds with "short" enums and "short" wchars. This means
that C/C++ enums will be packed into the smallest power of 2 number of
bytes by the compiler and the `wchar_t` is 2 bytes. Arm compiler 6
defaults to packing enums into 4 bytes and `wchar_t` is 4 bytes.
Further, Arm Compiler 5's `-O0` (no optimizations) bulids will actually
do some amount of optimizing, similar to Arm Compiler 6's `-O1`. I have
switched the debug profile to `-O1` for maximum compatibility with our
prior behavior.
NOTE: "Compatibilize" is a word
### Pull request type
[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
|
@theotherjimmy Looks like your script missed a new line. |
cmonr
changed the title
|
@cmonr Thanks for the reformatting. |
kegilbert
approved these changes
Nov 20, 2018
There was a problem hiding this comment.
Collected some rudimentary benchmarks at @theotherjimmy 's request, changes look solid to me.
kjbracey
approved these changes
Nov 20, 2018
0xc0170
approved these changes
Nov 20, 2018
|
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
|
Restarted test + dynamic CI jobs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Arm compiler 5 builds with "short" enums and "short" wchars. This means
that C/C++ enums will be packed into the smallest power of 2 number of
bytes by the compiler and the
wchar_tis 2 bytes. Arm compiler 6defaults to packing enums into 4 bytes and
wchar_tis 4 bytes.Further, Arm Compiler 5's
-O0(no optimizations) bulids will actuallydo some amount of optimizing, similar to Arm Compiler 6's
-O1. I haveswitched the debug profile to
-O1for maximum compatibility with ourprior behavior.
NOTE: "Compatibilize" is a word
Pull request type