[Seeed Arch MAX] Add Mbed OS 5 support #8831

toyowata · 2018-11-21T15:32:02Z

Description

Add Mbed OS 5 support for Seeed Arch MAX target.

Test result

RTC related test cases failed. I believe this is same issue here: #8196

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

cc @MarceloSalazar @ytsuboi

toyowata · 2018-11-26T04:34:53Z

@ashok-rao bump

0xc0170

Was IAR support removed or just not yet added ? files are there, it was ready, was there a specific reason not having IAR support.

toyowata · 2018-11-27T01:15:26Z

@0xc0170 The IAR support was not yet added. The startup code and linker script were added before, but not in the targets.json. So, I added and ran tests.

ashok-rao

Thanks @toyowata .. I've left some minor comments. Otherwise LGTM!

ashok-rao · 2018-11-28T09:56:42Z

targets/targets.json

        "program_cycle_s": 2,
        "extra_labels_add": [
            "STM32F4",
            "STM32F407",
            "STM32F407xG",
-            "STM32F407VG"
+            "STM32F407VG",
+            "STM_EMAC"


@toyowata : STM_EMAC - so, any default network interface on the board? If yes, you may want to add this here as well?

@ashok-rao Thanks. I added network-default-interface-type.

ashok-rao · 2018-11-28T09:57:02Z

targets/targets.json

+        "macros_add": ["USB_STM_HAL"],
+        "config": {
+            "clock_source": {
+                "help": "Mask value : USE_PLL_HSE_EXTC (need HW patch) | USE_PLL_HSE_XTAL (need HW patch) | USE_PLL_HSI | USE_PLL_MSI",


Help text: Does it need any HW patch or can this be removed?

ashok-rao · 2018-11-28T09:58:01Z

targets/targets.json

+            }
+        },
+        "release_versions": ["2", "5"],
+        "overrides": {"lse_available": 0},


This line makes use of LSI for RTC .. but still we see RTC failing.. General comment for @0xc0170 : I have seen this happening on all F4 series for the RTC .. this is something we need to investigate more on..

If there is not yet issue reported, please do

0xc0170 · 2018-11-28T10:17:16Z

Note, will require rebase

0xc0170 · 2018-12-06T11:49:33Z

@toyowata Can you rebase? This will be ready for CI

toyowata · 2018-12-07T02:08:55Z

@0xc0170 apply suggestion from @ashok-rao and rebased.

cmonr · 2018-12-07T03:01:49Z

@toyowata Sorry, but it looks like a mistake was made when doing the rebase.

If you look at the commits, Merge remote-tracking branch 'upstream/master' into dev-arch_max should not be there.

A rebase generally involves the following commands:

git fetch upstream master
git rebase upstream/master

Sometimes we can be a bit leniant on if a PR has a merge commit, but that's only if a PR is coming in to a feature release. Since 5.11 is currently in testing, that's not the case here.

Please correct this PR's commit history.
A command you may find useful: git reset --soft HEAD~1

toyowata · 2018-12-08T06:30:37Z

@cmonr Thank you. I think it should be fine now.

cmonr · 2018-12-10T17:02:52Z

@ashok-rao Please re-review. Looks like all of your comments have been addressed.

ashok-rao

Thanks @toyowata . LGTM!

cmonr · 2018-12-10T20:52:24Z

CI started

cmonr · 2018-12-11T02:07:45Z

CI jobs stopped: jenkins-ci/exporter, jenkins-ci/greentea-test

Prioritizing RC3 PRs. Will restart when able.

mbed-ci · 2018-12-11T02:17:59Z

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test
jenkins-ci/mbed-os-ci_exporter

JojoS62 · 2018-12-11T04:46:57Z

There is another issue with this target: it uses F407VG MCU as base setting, but has a F407VE as in the board documents. The difference is the flash size, program size >512MB will not run but create no linker error.

0xc0170 · 2018-12-11T08:50:08Z

There is another issue with this target: it uses F407VG MCU as base setting, but has a F407VE as in the board documents. The difference is the flash size, program size >512MB will not run but create no linker error.

@toyowata Please review

toyowata · 2018-12-11T10:18:42Z

@JojoS62 Thank you for your comment and concern. I agree with you.
@0xc0170 The base MCU type for this was wrongly defined when the Arch MAX platform was ported. I have raised the issue here: #9048

0xc0170 · 2018-12-11T10:44:28Z

OK, so to proceed here, this will be as it is (using current target base).

Will restart CI once rc3 is completed

cmonr · 2018-12-12T17:46:21Z

CI jobs restarted:

jenkins-ci/mbed-os-ci_greentea-test
jenkins-ci/mbed-os-ci_exporter

0xc0170 added the needs: review label Nov 21, 2018

0xc0170 requested a review from ashok-rao November 21, 2018 16:15

0xc0170 reviewed Nov 26, 2018

View reviewed changes

cmonr added the scope: new-target label Nov 26, 2018

ashok-rao reviewed Nov 28, 2018

View reviewed changes

0xc0170 approved these changes Nov 28, 2018

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Dec 6, 2018

cmonr added needs: CI needs: work and removed needs: work needs: CI labels Dec 7, 2018

toyowata force-pushed the dev-arch_max branch 3 times, most recently from 06446aa to 440fa2a Compare December 8, 2018 06:01

toyowata and others added 2 commits December 8, 2018 15:24

[Seeed Arch MAX] Add Mbed OS 5 support

91296c8

Add network-default-interface-type and remove comment

4d11ff8

toyowata force-pushed the dev-arch_max branch from 440fa2a to 4d11ff8 Compare December 8, 2018 06:28

cmonr added needs: review and removed needs: work labels Dec 10, 2018

cmonr added the release-version: 5.11.1 label Dec 10, 2018

ashok-rao approved these changes Dec 10, 2018

View reviewed changes

cmonr added needs: CI and removed needs: review labels Dec 10, 2018

0xc0170 added needs: review and removed needs: CI labels Dec 11, 2018

0xc0170 added needs: CI and removed needs: review labels Dec 12, 2018

cmonr merged commit f196942 into ARMmbed:master Dec 12, 2018

cmonr removed the needs: CI label Dec 12, 2018

toyowata deleted the dev-arch_max branch December 17, 2018 04:49

[Seeed Arch MAX] Add Mbed OS 5 support #8831

[Seeed Arch MAX] Add Mbed OS 5 support #8831

Uh oh!

Conversation

toyowata commented Nov 21, 2018

Description

Test result

Pull request type

Uh oh!

toyowata commented Nov 26, 2018

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

toyowata commented Nov 27, 2018

Uh oh!

ashok-rao left a comment

Choose a reason for hiding this comment

Uh oh!

ashok-rao Nov 28, 2018

Choose a reason for hiding this comment

Uh oh!

toyowata Dec 7, 2018

Choose a reason for hiding this comment

Uh oh!

ashok-rao Nov 28, 2018

Choose a reason for hiding this comment

Uh oh!

toyowata Dec 7, 2018

Choose a reason for hiding this comment

Uh oh!

ashok-rao Nov 28, 2018

Choose a reason for hiding this comment

Uh oh!

0xc0170 Nov 28, 2018

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Nov 28, 2018

Uh oh!

0xc0170 commented Dec 6, 2018

Uh oh!

toyowata commented Dec 7, 2018

Uh oh!

cmonr commented Dec 7, 2018

Uh oh!

toyowata commented Dec 8, 2018

Uh oh!

cmonr commented Dec 10, 2018

Uh oh!

ashok-rao left a comment

Choose a reason for hiding this comment

Uh oh!

cmonr commented Dec 10, 2018

Uh oh!

cmonr commented Dec 11, 2018

Uh oh!

mbed-ci commented Dec 11, 2018

Test run: FAILED

Uh oh!

JojoS62 commented Dec 11, 2018

Uh oh!

0xc0170 commented Dec 11, 2018

Uh oh!

toyowata commented Dec 11, 2018

Uh oh!

0xc0170 commented Dec 11, 2018

Uh oh!

cmonr commented Dec 12, 2018

Uh oh!

Uh oh!