Skip to content

Cellular: update doxygen and add attach CellularDevice. #8852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 7, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Nov 23, 2018

  • updated doxygen to better match function behavior
  • added method attach to CellularDevice. There are methods that are asynchronous but these was now callback possibility.

@AriParkkila please review

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 26, 2018

As we are still waiting for docs review, I would suggest one quick fix. Split this commit into two as stated

  • add Callback functionality
  • update doxygen

This helps reviewers (in this case docs team) to review only second commit for instance.

@0xc0170 0xc0170 changed the title Cellular: updated doxygen and added attach CellularDevice. Cellular: update doxygen and add attach CellularDevice. Nov 26, 2018
@jarvte jarvte force-pushed the cellular_doxygen_update branch from dc7d58f to 76672db Compare November 27, 2018 06:05
@jarvte
Copy link
Contributor Author

jarvte commented Nov 27, 2018

Split in to 2 commits. Second commit has also one new doxygen comment which comes with new method.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2018

@melwee01 Can you review?

@melwee01
Copy link
Contributor

melwee01 commented Dec 5, 2018

Will give it a look after lunch.

@mbed-ci
Copy link

mbed-ci commented Dec 5, 2018

Test run: FAILED

Summary: 5 of 7 test jobs failed
Build number : 1
Build artifacts
Build logs

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2018

CI restarted (Aborted previously)

@mbed-ci
Copy link

mbed-ci commented Dec 5, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts
Build logs

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2018

Waiting for docs team to approve, then ready for merge

@cmonr
Copy link
Contributor

cmonr commented Dec 5, 2018

@ARMmbed/mbed-docs Feel free to do your thing.

If y'all need to copy-edit the PR, then that's fine. We can restart CI as needed.

Amanda Butler added 2 commits December 6, 2018 16:38
Edit file for complete sentences, consistent tense and correct commas.
Edit file for complete sentences and correct commas.
@cmonr
Copy link
Contributor

cmonr commented Dec 7, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 7, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@cmonr cmonr merged commit fce4dc6 into ARMmbed:master Dec 7, 2018
@jarvte jarvte deleted the cellular_doxygen_update branch December 10, 2018 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants