-
Notifications
You must be signed in to change notification settings - Fork 3k
Cellular: update doxygen and add attach CellularDevice. #8852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As we are still waiting for docs review, I would suggest one quick fix. Split this commit into two as stated
This helps reviewers (in this case docs team) to review only second commit for instance. |
dc7d58f
to
76672db
Compare
Split in to 2 commits. Second commit has also one new doxygen comment which comes with new method. |
@melwee01 Can you review? |
Will give it a look after lunch. |
Test run: FAILEDSummary: 5 of 7 test jobs failed Failed test jobs:
|
CI restarted (Aborted previously) |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Waiting for docs team to approve, then ready for merge |
@ARMmbed/mbed-docs Feel free to do your thing. If y'all need to copy-edit the PR, then that's fine. We can restart CI as needed. |
Edit file for complete sentences, consistent tense and correct commas.
Edit file for complete sentences and correct commas.
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
@AriParkkila please review
Pull request type