-
Notifications
You must be signed in to change notification settings - Fork 3k
Ble extended advertising doc fixes #8879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@AnotherButler The changes requested are in |
* same value. | ||
* | ||
* To get extra data from the advertising device, the scanner can send scan | ||
* requests to the advertiser that respond with a scan response. It is possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unclear what responds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melwee01 What do you think of : "the scanner can send scan requests to the advertiser; the advertiser may respond with scan responses."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Does this need rebase (and remove preceding PR ) ? |
I think it needs a rebase. |
578ab7d
to
8c4a1a7
Compare
@0xc0170 rebased. |
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Description
Address documentation request from #8738
Pull request type