Skip to content

Ble extended advertising doc fixes #8879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2018

Conversation

pan-
Copy link
Member

@pan- pan- commented Nov 27, 2018

Description

Address documentation request from #8738

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[X] Docs update
[ ] Test update
[ ] Breaking change

@pan-
Copy link
Member Author

pan- commented Nov 27, 2018

@AnotherButler The changes requested are in
ca72e65 .

* same value.
*
* To get extra data from the advertising device, the scanner can send scan
* requests to the advertiser that respond with a scan response. It is possible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unclear what responds

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melwee01 What do you think of : "the scanner can send scan requests to the advertiser; the advertiser may respond with scan responses."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better. 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 29, 2018

Does this need rebase (and remove preceding PR ) ?

@pan-
Copy link
Member Author

pan- commented Nov 29, 2018

I think it needs a rebase.

@pan- pan- force-pushed the ble-extended-advertising-doc-fixes branch from 578ab7d to 8c4a1a7 Compare November 29, 2018 13:52
@pan-
Copy link
Member Author

pan- commented Nov 29, 2018

@0xc0170 rebased.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 4, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 4, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

@cmonr cmonr merged commit b3b0501 into ARMmbed:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants