Add PSA code generation check in travis #8889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
reviewed
Nov 28, 2018
| - env: | ||
| - NAME=psa-autogen | ||
| script: | ||
| - python tools/spm/generate_partition_code.py |
There was a problem hiding this comment.
What this supposed to be doing ? Checking unstaged files (means the files have changed?) A comment here might help (also this will need docs PR - there're travi sjobs described)
There was a problem hiding this comment.
Added a comment
Basically it runs the code generation tool and checks if changes are required
0xc0170
previously requested changes
Nov 28, 2018
|
@0xc0170 All squashed and ready to go |
cmonr
reviewed
Nov 28, 2018
| - NAME=psa-autogen | ||
| script: | ||
| # Run SPM code generator and check that changes are not needed | ||
| - python tools/spm/generate_partition_code.py |
There was a problem hiding this comment.
Making sure, does this tool work in Python 2 and Python 3?
There was a problem hiding this comment.
tested on 2.7 and 3.7
bridadan
approved these changes
Nov 28, 2018
|
Will start CI when able. |
|
Will be tested soon, I'll add one more job for rc1 and this one will be next |
|
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PSA auto generated code needs to be kept updated, enforce that in traivs
Pull request type