Skip to content

Renesas : Add the setting of SD as components #8899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

TomoYamanaka
Copy link
Contributor

@TomoYamanaka TomoYamanaka commented Nov 29, 2018

Description

Renesas added the setting of "Components SD" at targets.json because our mbed boards are incorporated SD slot as standard equipment.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team November 29, 2018 09:09
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 29, 2018

Any tests run (component SD contains tests) ? Please share results

@TomoYamanaka
Copy link
Contributor Author

The test result related to component SD is here.
Test_GR_PEACH_GCC.txt
Test_GR_LYCHEE_GCC.txt

@cmonr
Copy link
Contributor

cmonr commented Dec 1, 2018

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2018

There was a building error

[Error] kv_config.cpp@477,0:  #20: identifier "SPI_MOSI" is undefined
[Error] kv_config.cpp@478,0:  #20: identifier "SPI_MISO" is undefined
[Error] kv_config.cpp@479,0:  #20: identifier "SPI_SCK" is undefined
[Error] kv_config.cpp@480,0:  #20: identifier "SPI_CS" is undefined
[Warning] kv_config.cpp@615,0:  #185-D: dynamic initialization in unreachable code
[Warning] kv_config.cpp@691,0:  #185-D: dynamic initialization in unreachable code
[Warning] kv_config.cpp@786,0:  #185-D: dynamic initialization in unreachable code
[Warning] kv_config.cpp@937,0:  #111-D: statement is unreachable
Failed to build library
Memory map breakdown for built projects (values in Bytes):
| name | target | toolchain | static_ram | total_flash |
|------|--------|-----------|------------|-------------|


Build failures:
  * VK_RZ_A1H::ARM::MBED-BUILD

Please review

@TomoYamanaka
Copy link
Contributor Author

TomoYamanaka commented Dec 3, 2018

@0xc0170
Sorry for my mistake. Could you re-trigger the CI start because I modified my commit?

My test results are here.
Test_PEACH_gcc.txt
Test_LYCHEE_gcc.txt

@cmonr
Copy link
Contributor

cmonr commented Dec 3, 2018

@TomoYamanaka

We can start CI as soon as this PR is rebased.
A fix for Travis CI was brought in a couple of hours ago.

@TomoYamanaka
Copy link
Contributor Author

TomoYamanaka commented Dec 4, 2018

@cmonr

I rebased. My test results are here.
Test_PEACH_GCC.txt
Test_LYCHEE_GCC.txt

@cmonr
Copy link
Contributor

cmonr commented Dec 4, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 4, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 2
Build artifacts
Build logs

@0xc0170 0xc0170 merged commit 4dfb97c into ARMmbed:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants