Nuvoton: Refine UART init/deinit #8900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… UART The same H/W UART may be shared by multiple serial_t objects. This fix tries to avoid re-configuring the same H/W UART in serial_init() when there are multiple serial_t objects constructed. To re-configure UART, call serial_baud() and serial_format() explicitly. This can avoid confusion when e.g. a newly constructed serial_t object changes baudrate unexpectedly in serial_init().
With support for checking H/W UART initialized or not, we can simplify stdio management: 1. When serial_init(&stdio_uart) calls in, just set the 'stdio_uart_inited' flag. 2. When serial_free(&stdio_uart) calls in, just clear the 'stdio_uart_inited' flag. Except above, we needn't make special handling with 'stdio_uart'.
|
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refines UART init/deinit, especially when there are multiple
serial_tstructs sharing the same H/W UART. It includes:pin_tx/pin_rxfields fromserial_sstructserial_init()stdio_uartTargets
NUMAKER_PFM_NANO130
NUMAKER_PFM_NUC472
NUMAKER_PFM_M453
NUMAKER_PFM_M487/NUMAKER_IOT_M487
NUMAKER_PFM_M2351
[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change