Cell refactor power api #8901

AriParkkila · 2018-11-29T10:56:42Z

Description

Moved AT functionality from cellular power class to CellularNetwork and CellularDevice:

Move eDRX setting from power to network
Move PSM setting from power to device
Move device_ready from power to device
AT remove_urc_handler changed to set_urc_handler(prefix, 0)
Move ready_cb from power to device
Unify set_at_mode and init_module into init()
Removed set_power_level()
Moved reset from power to device
Added shutdown()

The reason is that cellular power functionality, such as modem reset can't be different from CellularDevice due to that must inform any cellular user applications to reinitialize cellular network context and sockets.

To be merged in Mbed OS 5.12 (also documentation updated then).

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[x] Breaking change

AriParkkila · 2018-11-29T10:57:10Z

@jarvte @mirelachirica please review

jarvte

Shouldn't we remove the whole CellularPower api?

features/cellular/framework/API/CellularDevice.h

features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95.cpp

features/cellular/TESTS/socket/udp/main.cpp

AriParkkila · 2018-11-29T12:24:21Z

@jarvte amended the changes to top commit. I will make another PR for non-AT related functionality to remove power class completely.

cmonr · 2018-12-04T22:33:39Z

Hmm, Travis CI didn't update with the change from master to the feature branch.

Trying a thing.

cmonr · 2018-12-04T22:34:57Z

Neat! Travis CI took the change.

0xc0170 · 2018-12-05T12:58:22Z

Let's finalize the reviews !

cmonr · 2018-12-05T15:50:09Z

CI started

mbed-ci · 2018-12-05T16:40:20Z

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-IAR

cmonr · 2018-12-05T16:52:55Z

Will restart CI when able. There appears to be a parse error with the CI scripts.

alekla01 · 2018-12-05T17:44:45Z

CI restarted

cmonr · 2018-12-05T19:21:01Z

Looks like this'll need a rebase.

mbed-ci · 2018-12-05T19:34:13Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

AriParkkila · 2018-12-10T10:38:20Z

@cmonr just rebased

0xc0170 · 2018-12-10T13:06:10Z

CI started

mbed-ci · 2018-12-10T14:03:35Z

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR

cmonr · 2018-12-10T20:19:11Z

@ARMmbed/mbed-os-wan Please take a look at the last job's artifacts.

Specifically, it looks like the WIO_BG96 target is having trouble linking a couple of network tests across compilers.

Log for IAR:

  * WIO_BG96::IAR::TESTS-NETSOCKET-DNS
        Building project dns (WIO_BG96, IAR)
        Scan: IAR
        Scan: dns
        Compile [  6.7%]: asynchronous_dns.cpp
        Compile [ 13.3%]: asynchronous_dns_cache.cpp
        Compile [ 20.0%]: asynchronous_dns_cancel.cpp
        Compile [ 26.7%]: asynchronous_dns_external_event_queue.cpp
        Compile [ 33.3%]: asynchronous_dns_invalid_host.cpp
        Compile [ 40.0%]: asynchronous_dns_non_async_and_async.cpp
        Compile [ 46.7%]: asynchronous_dns_simultaneous.cpp
        Compile [ 53.3%]: asynchronous_dns_simultaneous_cache.cpp
        Compile [ 60.0%]: asynchronous_dns_simultaneous_repeat.cpp
        Compile [ 66.7%]: asynchronous_dns_timeouts.cpp
        Compile [ 73.3%]: main.cpp
        Compile [ 80.0%]: synchronous_dns.cpp
        Compile [ 86.7%]: synchronous_dns_cache.cpp
        Compile [ 93.3%]: synchronous_dns_invalid.cpp
        Compile [100.0%]: synchronous_dns_multiple.cpp
        Link: dns
        Error[Li005]: no definition for
                  "mbed::QUECTEL_BG96::set_ready_cb(mbed::Callback<void ()>)"
                  [referenced from /builds/ws/mbed-os-ci_build-IAR/WIO_BG96_IAR_889/mbe
                  d-os/./BUILD/tests/WIO_BG96/IAR/features/cellular/framework/device/Ce
                  llularStateMachine.o]
        
  * WIO_BG96::IAR::TESTS-NETWORK-INTERFACE
        Building project interface (WIO_BG96, IAR)
        Scan: IAR
        Scan: interface
        Compile [ 33.3%]: main.cpp
        Compile [ 66.7%]: networkinterface_conn_disc_repeat.cpp
        Compile [100.0%]: networkinterface_status.cpp
        [Warning] networkinterface_status.cpp@140,0: [Pe177]: variable "status" was declared but never referenced
        Link: interface
        Error[Li005]: no definition for
                  "mbed::QUECTEL_BG96::set_ready_cb(mbed::Callback<void ()>)"
                  [referenced from /builds/ws/mbed-os-ci_build-IAR/WIO_BG96_IAR_889/mbe
                  d-os/./BUILD/tests/WIO_BG96/IAR/features/cellular/framework/device/Ce
                  llularStateMachine.o]
        
  * WIO_BG96::IAR::TEST_APPS-DEVICE-SOCKET_APP
        Building project socket_app (WIO_BG96, IAR)
        Scan: IAR
        Scan: socket_app
        Compile [ 25.0%]: cmd_ifconfig.cpp
        Compile [ 50.0%]: cmd_socket.cpp
        Compile [ 75.0%]: main.cpp
        Compile [100.0%]: strconv.c
        Link: socket_app
        Error[Li005]: no definition for
                  "mbed::QUECTEL_BG96::set_ready_cb(mbed::Callback<void ()>)"
                  [referenced from /builds/ws/mbed-os-ci_build-IAR/WIO_BG96_IAR_889/mbe
                  d-os/./BUILD/tests/WIO_BG96/IAR/features/cellular/framework/device/Ce
                  llularStateMachine.o]

AriParkkila · 2018-12-11T07:05:51Z

@cmonr thanks I fixed rebase conflict, please restart CI.

cmonr · 2018-12-11T16:09:22Z

Will restart CI once RC3 PRs are done being prioritized.

0xc0170 · 2018-12-12T12:15:58Z

CI restarted

mbed-ci · 2018-12-12T16:44:38Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts

0xc0170 requested review from AnttiKauppila, jarvte and mirelachirica November 29, 2018 10:57

jarvte suggested changes Nov 29, 2018

View reviewed changes

features/cellular/framework/API/CellularDevice.h Outdated Show resolved Hide resolved

features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95.cpp Show resolved Hide resolved

features/cellular/TESTS/socket/udp/main.cpp Outdated Show resolved Hide resolved

0xc0170 added needs: review BREAKING-CHANGE labels Nov 29, 2018

AriParkkila force-pushed the cell-refactor-power-api branch from 5be4dc5 to 6321a88 Compare November 29, 2018 12:22

jarvte approved these changes Nov 29, 2018

View reviewed changes

AriParkkila changed the base branch from master to feature-cellular-refactor November 30, 2018 12:52

cmonr closed this Dec 4, 2018

cmonr removed the needs: review label Dec 4, 2018

cmonr reopened this Dec 4, 2018

cmonr added the needs: review label Dec 4, 2018

AnttiKauppila approved these changes Dec 5, 2018

View reviewed changes

0xc0170 added the release-version: feature branch label Dec 5, 2018

0xc0170 approved these changes Dec 5, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Dec 5, 2018

cmonr added needs: work and removed needs: CI labels Dec 5, 2018

Ari Parkkila added 8 commits December 9, 2018 23:58

Cellular: Move eDRX setting from power to network

1f744ef

Cellular: Move PSM setting from power to device

30bd353

Cellular: Move device_ready from power to device

ef2a091

Cellular: AT remove_urc_handler changed to set_urc_handler(prefix, 0)

6ec5f79

Cellular: Move ready_cb from power to device

7f7ffbe

Cellular: Unify set_at_mode and init_module into init()

09e2a7e

Cellular: Removed set_power_level()

5b2dc38

Cellular: Moved reset from power to device

65da29d

AriParkkila force-pushed the cell-refactor-power-api branch from 6321a88 to 3a2491a Compare December 10, 2018 10:35

0xc0170 added needs: CI and removed needs: work labels Dec 10, 2018

cmonr added needs: work and removed needs: CI labels Dec 10, 2018

Cellular: Added shutdown()

d09ee0d

AriParkkila force-pushed the cell-refactor-power-api branch from 3a2491a to d09ee0d Compare December 11, 2018 07:02

cmonr added needs: CI and removed needs: work labels Dec 11, 2018

cmonr added ready for merge and removed needs: CI labels Dec 12, 2018

cmonr merged commit a57bacf into ARMmbed:feature-cellular-refactor Dec 12, 2018

cmonr removed the ready for merge label Dec 12, 2018

Cell refactor power api #8901

Cell refactor power api #8901

Uh oh!

Conversation

AriParkkila commented Nov 29, 2018

Description

Pull request type

Uh oh!

AriParkkila commented Nov 29, 2018

Uh oh!

jarvte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AriParkkila commented Nov 29, 2018

Uh oh!

cmonr commented Dec 4, 2018

Uh oh!

cmonr commented Dec 4, 2018

Uh oh!

0xc0170 commented Dec 5, 2018

Uh oh!

cmonr commented Dec 5, 2018

Uh oh!

mbed-ci commented Dec 5, 2018

Test run: FAILED

Uh oh!

cmonr commented Dec 5, 2018

Uh oh!

alekla01 commented Dec 5, 2018

Uh oh!

cmonr commented Dec 5, 2018

Uh oh!

mbed-ci commented Dec 5, 2018

Test run: SUCCESS

Uh oh!

AriParkkila commented Dec 10, 2018

Uh oh!

0xc0170 commented Dec 10, 2018

Uh oh!

mbed-ci commented Dec 10, 2018

Test run: FAILED

Uh oh!

cmonr commented Dec 10, 2018

Uh oh!

AriParkkila commented Dec 11, 2018

Uh oh!

cmonr commented Dec 11, 2018

Uh oh!

0xc0170 commented Dec 12, 2018

Uh oh!

mbed-ci commented Dec 12, 2018

Test run: SUCCESS

Uh oh!

Uh oh!