Ble extended advertising fixes #8904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion parameter. Unlike the public address, the RANDOM address is guaranteed to exist. If privacy is enabled, it means the controller will generates random resolvable addresses or non resolvable addresses depending on the config. If privacy is not enabled then the device will use the device's random static address that doesn't change between radio processes.
|
This are fixes for recent feature (5.11 one), is that correct? |
| @@ -145,10 +145,10 @@ class ConnectionParameters { | |||
| phy_t phy = phy_t::LE_1M, | |||
| scan_interval_t scanInterval = scan_interval_t::min(), | |||
| scan_window_t scanWindow = scan_window_t::min(), | |||
| conn_interval_t minConnectionInterval = conn_interval_t::min(), | |||
| conn_interval_t maxConnectionInterval = conn_interval_t::max(), | |||
| conn_interval_t minConnectionInterval = conn_interval_t(50), | |||
There was a problem hiding this comment.
any reason for these particular values?
There was a problem hiding this comment.
Yes, they are more balanced with common use cases than the previous one (62 to 124 ms for the connection interval instead of 7.5 to 4 seconds).
paul-szczepanek-arm
approved these changes
Nov 29, 2018
|
@0xc0170 Correct. |
|
Looks good! |
|
More fixes incoming. |
|
@donatieng @paul-szczepanek-arm Could you re-review ?
@cmonr I think that's all. |
donatieng
suggested changes
Dec 3, 2018
| scan_duration_t duration = scan_duration_t::forever(), | ||
| duplicates_filter_t filtering = duplicates_filter_t::DISABLE, |
This change makes it consistent with PeriodicAdvertisingReportEvent.
donatieng
approved these changes
Dec 3, 2018
|
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the examples revealed few defects in the ble extended feature. This PR intend to fix those.
We're waiting for OOB to add more if necessary.
Pull request type
The "breaking changes" are in the new API:
Pull request type