Fix PSA internal storage configuration #8908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny4478
suggested changes
Dec 2, 2018
components/TARGET_PSA/services/psa_prot_internal_storage/COMPONENT_PSA_SRV_IMPL/pits_impl.cpp
Show resolved
Hide resolved
components/TARGET_PSA/services/psa_prot_internal_storage/COMPONENT_PSA_SRV_IMPL/pits_impl.cpp
Outdated
Show resolved
Hide resolved
components/TARGET_PSA/services/psa_prot_internal_storage/COMPONENT_PSA_SRV_IMPL/pits_impl.cpp
Show resolved
Hide resolved
components/TARGET_PSA/services/psa_prot_internal_storage/COMPONENT_PSA_SRV_IMPL/pits_impl.cpp
Outdated
Show resolved
Hide resolved
components/TARGET_PSA/services/psa_prot_internal_storage/COMPONENT_PSA_SRV_IMPL/pits_impl.cpp
Show resolved
Hide resolved
components/TARGET_PSA/services/psa_prot_internal_storage/COMPONENT_PSA_SRV_IMPL/pits_impl.cpp
Show resolved
Hide resolved
components/TARGET_PSA/services/psa_prot_internal_storage/COMPONENT_PSA_SRV_IMPL/pits_impl.cpp
Show resolved
Hide resolved
danny4478
reviewed
Dec 2, 2018
components/TARGET_PSA/services/psa_prot_internal_storage/COMPONENT_PSA_SRV_IMPL/pits_impl.cpp
Outdated
Show resolved
Hide resolved
danny4478
approved these changes
Dec 3, 2018
dannybenor
approved these changes
Dec 3, 2018
|
@alzix rebase ontop of master so traivs will pass and maybe we'll be able to get this into rc2 |
|
rebased on master |
|
One code style change proposed in the failing astyle, then it should all be ok in travis |
added 4 commits
December 4, 2018 14:08
Use internal TDBStore instance instead of default one
PID should come first to create - to prevent timing attacks. Each partition can only request its own files. Thus starting lookup from the PID makes more sence.
PSA PID is of int32_t type - use native type during the whole flow for better readability. Convert PID to unsigned for calculations only. Add dedicated inline function for logic shift right.
|
0xc0170
approved these changes
Dec 4, 2018
|
CI started Note, this one is still labeled for 5.11.1 (rc2 not ?) |
|
rc2 |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
cmonr
added
release-version: 5.11.0-rc2
ready for merge
and removed
release-version: 5.11.1
needs: CI
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix PSA internal storage configuration.
Explicitly request for internal flash TDBStore instance instead of default KVStore instance.
CC @dannybenor @danny4478
Pull request type