MODULE_UBLOX_ODIN_W2: disable MPU code until target properly supported #8920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xc0170 @kjbracey-arm please take a look |
0xc0170
approved these changes
Nov 30, 2018
|
cc @ARMmbed/team-ublox |
c1728p9
approved these changes
Nov 30, 2018
|
I created issue #8930 fix the null pointer dereference that the MPU is catching. Once that issue is resolved the MPU can be re-enabled for the MODULE_UBLOX_ODIN_W2. |
|
This same problem also effects the |
|
@c1728p9 I believe it should be already turned off for UBLOX_EVK_ODIN_W2 as it inherits these settings from MODULE_UBLOX_ODIN_W2? |
|
@c1728p9 and nice catch btw, good work! |
|
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The target and its derivatives started HardFaulting since the MPU overhaul commit (1821d37). This was visible in network greentea tests and well as cloud connectivity tests. This is a workaround which disables the MPU code for the target. A proper fix would be target specific routines.
Pull request type