Skip to content

Fix PSA storage typo #8925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2018
Merged

Fix PSA storage typo #8925

merged 2 commits into from
Dec 4, 2018

Conversation

Patater
Copy link
Contributor

@Patater Patater commented Nov 30, 2018 •
edited
Loading

Description

Fix PSA_PS_ERROR_OFFSET_INVALID typo in both storage and crypto. These must be changed at the same time in order for each project's CI to remain green.

CC @alzix @dannybenor

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@Patater Patater changed the title DO NOT MERGE Fix crypto and storage configuration DO NOT MERGE Fix storage typo Nov 30, 2018
@Patater Patater changed the title DO NOT MERGE Fix storage typo DO NOT MERGE Fix PSA storage typo Nov 30, 2018
@Patater
crypto: storage: Fix PSA_PS_ERROR_OFFSET typo
f9417ac 
Correct typo of PSA_PS_ERROR_OFFSET to PSA_ITS_ERROR_OFFSET.
@Patater
psa: storage: Fix PSA_PS_ERROR_OFFSET typo
6de7c18 
Correct typo of PSA_PS_ERROR_OFFSET to PSA_ITS_ERROR_OFFSET.
@Patater Patater force-pushed the crypto-storage-config-fixes branch from c4f4338 to 6de7c18 Compare November 30, 2018 15:36
@Patater Patater changed the title DO NOT MERGE Fix PSA storage typo Fix PSA storage typo Nov 30, 2018
@cmonr cmonr requested a review from a team December 1, 2018 01:21
@cmonr cmonr requested review from alzix and dannybenor December 1, 2018 01:22
@cmonr
Copy link
Contributor

cmonr commented Dec 1, 2018

@Patater Out of curiosity, why is this prefixed with DO NOT MERGE?

@cmonr
Copy link
Contributor

cmonr commented Dec 1, 2018

Whoops. Wrong PR.

@cmonr cmonr removed the do not merge label Dec 1, 2018
alzix
alzix approved these changes Dec 1, 2018
View reviewed changes
Copy link
Contributor

@alzix alzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I would suggest to merge it in to rc2.
@Patater, can we merge it here and in parallel you will update your crypto repo?

@cmonr
Copy link
Contributor

cmonr commented Dec 1, 2018

I would suggest to merge it in to rc2.
Fyi @ARMmbed/mbed-os-maintainers

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 4, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 4, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

@0xc0170 0xc0170 merged commit e02a8ab into ARMmbed:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@alzix alzix alzix approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

@dannybenor dannybenor Awaiting requested review from dannybenor

Assignees
No one assigned
Labels
release-version: 5.11.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Patater @cmonr @0xc0170 @mbed-ci @alzix @gilles-peskine-arm