Skip to content

mbedtls: Update Mbed TLS to 2.15.1 #8926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2018
Merged

mbedtls: Update Mbed TLS to 2.15.1 #8926

merged 1 commit into from
Dec 4, 2018

Conversation

Patater
Copy link
Contributor

@Patater Patater commented Nov 30, 2018

Description

Update Mbed TLS to version 2.15.1. Fixes #8893.

Targeting Mbed OS 5.11.0rc2 in order to fix Client PR job

CC @sbutcher-arm

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@Patater
Copy link
Contributor Author

Patater commented Nov 30, 2018

This is a placeholder PR until Mbed TLS 2.15.1 is released. After which, this PR will be updated with the actual release.

@cmonr cmonr requested a review from simonbutcher December 1, 2018 01:23
@0xc0170 0xc0170 mentioned this pull request Dec 3, 2018
Closed
@Patater Patater changed the title DO NOT MERGE mbedtls: Update Mbed TLS to 2.15.1 mbedtls: Update Mbed TLS to 2.15.1 Dec 3, 2018
@Patater
Copy link
Contributor Author

Patater commented Dec 3, 2018

This is OK to consider merging now.

@cmonr
Copy link
Contributor

cmonr commented Dec 3, 2018

@sbutcher-arm All good?

@cmonr
Copy link
Contributor

cmonr commented Dec 3, 2018

CI started

cmonr
cmonr approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now.

features/mbedtls/VERSION.txt
mbedtls-2.15.0
mbedcrypto-0.1.0b
mbedtls-2.15.1
mbedcrypto-0.1.0b2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has me a bit worried, but fine for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's worrying?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why worried? That's like half a comment - it's wrong but you're not saying how. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair feedback.

mbedcrypto-0.1.0b2

This gives mes the impression that another TLS update will be needed before the feature release is complete. Is that correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the second beta of Mbed Crypto 0.1.0, hence the version. This version scheme doesn't imply there will be more, but there could be should we need. ;)

simonbutcher
simonbutcher approved these changes Dec 3, 2018
View reviewed changes
features/mbedtls/VERSION.txt
mbedtls-2.15.0
mbedcrypto-0.1.0b
mbedtls-2.15.1
mbedcrypto-0.1.0b2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why worried? That's like half a comment - it's wrong but you're not saying how. :)

@Patater
Copy link
Contributor Author

Patater commented Dec 3, 2018

This is ready for CI

@cmonr
Copy link
Contributor

cmonr commented Dec 3, 2018

#8926 (comment)

;)

@Patater
Copy link
Contributor Author

Patater commented Dec 3, 2018

Correction, this is ready for CI results to start coming in... :p

@mbed-ci
Copy link

mbed-ci commented Dec 4, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts
Build logs

@cmonr
Copy link
Contributor

cmonr commented Dec 4, 2018

Rerunning greentea CI in case the line K82F IAR test failure was some sort of glitch.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 4, 2018

This is OK to consider merging now.

Ready, going in now

@0xc0170 0xc0170 merged commit 992bcba into ARMmbed:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@simonbutcher simonbutcher simonbutcher approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation error with psa_crypto.c
5 participants
@Patater @cmonr @mbed-ci @0xc0170 @simonbutcher