Reduce default MBEDTLS_MPI_MAX_SIZE #8936
Conversation
|
Travis failure will be fixed on master soon (we will request rebase once done). See #8945 |
| @@ -140,6 +140,8 @@ conf unset MBEDTLS_SSL_TRUNCATED_HMAC | |||
|
|
|||
| conf unset MBEDTLS_PLATFORM_TIME_TYPE_MACRO | |||
|
|
|||
| conf set MBEDTLS_MPI_MAX_SIZE 512 | |||
There was a problem hiding this comment.
May be worth adding a comment on effects of this limitation, as well as its benefits.
There was a problem hiding this comment.
I added a comment, as asked
The fix is on master, if you rebase, it should allow travis to run |
|
OK, I'll rebase. Do you want me to squash the two commits while I'm on it? |
|
@RonEld No need to squash. Both commits look good asis. |
Reduce the default size of `MBEDTLS_MPI_MAX_SIZE` to 512 bytes, as the default 1024 consumes much stack, and supporting RSA 4096 bit may suffice at the moment.
Add a comment in the `adjust-config.sh` script, for effects and benefits of the new value.
RonEld
force-pushed
the
reduce_default_mpi_max_size
branch
from
abadb4e to
edc09cf
Compare
There was a problem hiding this comment.
Note that our TLS Client example uses 256 here. https://github.com/ARMmbed/mbed-os-example-tls/blob/master/tls-client/mbedtls_entropy_config.h#L36
|
CI started |
Thanks for the reminder! I have created ARMmbed/mbed-os-example-tls#220 to avoid future compilation warnings. |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
|
Will restart CI once rc 2 is completed (the failure is new, not related, we will track it and report back) |
|
CI restarted |
Description
Reduce the default size of
MBEDTLS_MPI_MAX_SIZEto 512 bytes,as the default 1024 consumes much stack, and supporting RSA 4096 bit
may suffice at the moment.
Pull request type