spi-overhaul: add limitation for spi async API #8966
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mprse, thank you for your changes. |
cmonr
force-pushed
the
feature-hal-spec-spi
branch
from
a290cfe to
0892667
Compare
mprse
force-pushed
the
feature-hal-spec-spi_doc_fix_async
branch
from
7e435f2 to
ab61114
Compare
0xc0170
previously requested changes
Dec 5, 2018
There was a problem hiding this comment.
Add to the commit msg:
Handling buffers of a different sizes or half-duplex transfer in asyc mode might be very tricky and is a potential place for many problems. This PR changes the documentation to allow only equal buffer sizes and full duplex transfer in async mode.
Handling buffers of a different sizes or half-duplex transfer in asyc mode might be very tricky and is a potential place for many problems. This PR changes the documentation to allow only equal buffer sizes and full duplex transfer in async mode.
mprse
force-pushed
the
feature-hal-spec-spi_doc_fix_async
branch
from
ab61114 to
7eb7df9
Compare
Done! |
cmonr
approved these changes
Dec 14, 2018
|
CI started |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handling buffers of a different sizes or half-duplex transfer in asyc mode might be very tricky and is a potential place for many problems. This PR changes the documentation to allow only equal buffer sizes and full duplex transfer in async mode.
cc @c1728p9 @ithinuel
Pull request type