Skip to content

Add Travis CI check to block PRs opened from ARMmbed/mbed-os #8968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Dec 4, 2018

Description

We've recently had several PRs that were opened that were branches from the ARMmbed account:

Having access controls is for some reason not enough, so adding a check in Travis CI that checks to make sure the PR head is not from the ARMmbe account.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@cmonr cmonr requested a review from a team December 4, 2018 21:33
@cmonr cmonr changed the title Added check to make sure PR is not opened from ARMmbed account Travis CI check to make sure PR is not opened from ARMmbed account Dec 4, 2018
@cmonr cmonr changed the title Travis CI check to make sure PR is not opened from ARMmbed account Add Travis CI check to block PRs opened from ARMmbed/mbed-os Dec 4, 2018
@cmonr cmonr closed this Dec 4, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2018

Why was this closed?

@cmonr
Copy link
Contributor Author

cmonr commented Dec 5, 2018

Oh, thought I left a comment.

The fix asis would have prevented feature branches from being merged :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants