Skip to content

Initialize the interface at the construction #8975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2018
Merged

Initialize the interface at the construction #8975

merged 1 commit into from
Dec 18, 2018
+43 −9

Conversation

KariHaapalehto
Copy link
Contributor

and make sure that it's done only once.

Description

Interface is initialized at construction.
This will make it possible to read mac-address before mesh.connect()

Tested locally that correction is working with mbed-os-example-mesh-minimal and K66F

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

kjbracey
kjbracey previously requested changes Dec 5, 2018
View reviewed changes
features/nanostack/mbed-mesh-api/source/LoWPANNDInterface.cpp
nsapi_error_t result = interface.initialize(&NanostackRfPhy::get_default_instance());
if (result != 0) {
tr_error("LoWPANND initialize failed: %d", error);
return NULL;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing singleton_unlock here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sinleton_unlock's has been added

@KariHaapalehto
Copy link
Contributor Author

need more work

@KariHaapalehto
Copy link
Contributor Author

Don't need more work, can be proceed

@cmonr
Copy link
Contributor

cmonr commented Dec 10, 2018

@KariHaapalehto Will start once all RC3 PRs are in.

Out of curiosity, what changed in the past five days that indicated that this no longer needed more work?

@cmonr
Copy link
Contributor

cmonr commented Dec 10, 2018

@kjbracey-arm It sounds like this is ready for a re-review.

@KariHaapalehto
Copy link
Contributor Author

KariHaapalehto commented Dec 11, 2018 •
edited by cmonr
Loading

what changed in the past five days that indicated that this no longer needed more work?

I was testing this locally with mbed-os-mesh-minimal and just before I left for extended weekend I notice, that change didn't compile with mesh_6lowpan.json-config. So I did changed status to "need work".
But when I came back from short holiday, I did discuss with @kjbracey-arm and he told me that my failing building configuration was incorrect. So nothing has change in past five days, just my first assumption was incorrect.

@0xc0170 0xc0170 dismissed kjbracey’s stale review December 14, 2018 15:40

Updated, needs rereview

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 8bd9772 into ARMmbed:master Dec 18, 2018
@KariHaapalehto KariHaapalehto deleted the fix_valid_mac_address branch December 19, 2018 08:03
@KariHaapalehto KariHaapalehto mentioned this pull request Dec 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey kjbracey approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KariHaapalehto @cmonr @0xc0170 @mbed-ci @kjbracey