Skip to content

Fix uninitialized handler pointer in FastModels ethernet driver #8996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2018
Merged

Fix uninitialized handler pointer in FastModels ethernet driver #8996

merged 1 commit into from
Dec 7, 2018

Conversation

jamesbeyond
Copy link
Contributor

Description

This is the fix for ARMmbed/mbed-os-example-sockets#104.
This is fixed the bug of uninitialized handler pointer, which didn't expose until we got MPU enabled in mbed OS.

cc @ashok-rao @TacoGrandeTX @MarceloSalazar

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested a review from a team December 7, 2018 00:00
@ciarmcom
Copy link
Member

ciarmcom commented Dec 7, 2018

@jamesbeyond, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

cmonr
cmonr approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adbridge
Copy link
Contributor

adbridge commented Dec 7, 2018

@SeppoTakalo could you review please

@adbridge adbridge requested a review from SeppoTakalo December 7, 2018 11:22
@ashok-rao
Copy link
Contributor

Checked out the PR locally and tested. Passes fine. Thanks @jamesbeyond .

For the records:

C:\Ashok\temp\OoB_5_11\mbed-os-example-sockets\mbed-os>mbed ls
mbed-os (#f8edab12f48a)

C:\Ashok\temp\OoB_5_11\mbed-os-example-sockets\mbed-os>git log
commit f8edab12f48a712c6c5dd2ef24c01cc0c09057b0 (HEAD -> pr-8996)
Author: Qinghao Shi <[email protected]>
Date:   Thu Dec 6 23:38:28 2018 +0000

    fix uninitialized handler pointer in ethernet driver

pr-8996

@ashok-rao ashok-rao mentioned this pull request Dec 7, 2018
Closed
@adbridge
Copy link
Contributor

adbridge commented Dec 7, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 7, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 0e3d712 into ARMmbed:master Dec 7, 2018
@jamesbeyond jamesbeyond deleted the fm_eth_fix branch December 10, 2018 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@ashok-rao ashok-rao ashok-rao approved these changes

@TacoGrandeTX TacoGrandeTX Awaiting requested review from TacoGrandeTX

@MarceloSalazar MarceloSalazar Awaiting requested review from MarceloSalazar

Assignees
No one assigned
Labels
release-version: 5.11.0-rc3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jamesbeyond @ciarmcom @adbridge @ashok-rao @mbed-ci @cmonr @SeppoTakalo