-
Notifications
You must be signed in to change notification settings - Fork 3k
Missing socket greentea tests implementation #9001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing socket greentea tests implementation #9001
Conversation
@SeppoTakalo , @VeijoPesonen , @KariHaapalehto , please review. |
Check the Astyle errors. |
Also.. Do we want this to be copy&pasted on every single test case: #if MBED_CONF_NSAPI_SOCKET_STATS_ENABLE
int count = fetch_stats();
for (int j = 0; j < count; j++) {
TEST_ASSERT_EQUAL(SOCK_CLOSED, tcp_stats[j].state);
}
#endif I'm fine for it now, but feel like we should refactor socket stats to its own test, so there would be less boilerplate to copy&paste on every single test case. |
c518fe2
to
c48312d
Compare
Astyle fixed, I created an internal task ONME-4070, to make sure we refactor the socket stats. |
@michalpasztamobica, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward.
CI started |
Test run: SUCCESSSummary: 9 of 9 test jobs passed |
Description
The TCP/UDP socket tests status is now fully in line with the test plan, with the exception of missing getsockopt implementation in LWIP stack.
Pull request type