-
Notifications
You must be signed in to change notification settings - Fork 3k
Mbed os 5.11.0 oob: fix fault exception issue #9025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mbed os 5.11.0 oob: fix fault exception issue #9025
Conversation
…r parameter as SocketAddress *addr.
@tz-arm, thank you for your changes. |
@AnttiKauppila @AriParkkila As this seems to only be affecting one target I am marking this 5.11.1 |
@adbridge a little confused about "only be affecting one target", could you share more why it is relevant to target? thanks. |
@adbridge Am confused by the statement as well. The original issue was reported with a single target, but the fix is considerably more generic. Moved to RC3, and will let the eastern hemisphere sort it out. @tz-arm This PR still needs work. Please take a look at the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fix astyle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run:
astyle.exe -n --options=.astylerc features/cellular/framework/AT/AT_CellularStack.cpp
@cmonr @adbridge @AriParkkila, thanks for your comments, I understand where the target confusion come from: |
The report was fine (reported target that you tested on, the bug was found in the generic layer) |
Test restarted (failed due to not enough space , fixed now) |
Test run: FAILEDSummary: 2 of 11 test jobs failed Failed test jobs:
|
Last CI job somehow got stuck at starting the exporter jobs, even though CI was completely empty. Restarted Because original job was never started, there was nothing to restart. Had to manually fill in job parameters. On success, should make |
Description
Fix the fault exception issue in socket_recvfrom().
It is caused by the usage of null pointer as SocketAddress *addr.
e.g. socket_recv() -> socket_recvfrom(handle, NULL, data, size);
Pull request type