Skip to content

Mbed os 5.11.0 oob: fix fault exception issue #9025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tz-arm
Copy link
Contributor

@tz-arm tz-arm commented Dec 10, 2018

Description

Fix the fault exception issue in socket_recvfrom().
It is caused by the usage of null pointer as SocketAddress *addr.
e.g. socket_recv() -> socket_recvfrom(handle, NULL, data, size);

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom
Copy link
Member

@tz-arm, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@adbridge
Copy link
Contributor

@AnttiKauppila @AriParkkila As this seems to only be affecting one target I am marking this 5.11.1

@tz-arm
Copy link
Contributor Author

tz-arm commented Dec 11, 2018

@adbridge a little confused about "only be affecting one target", could you share more why it is relevant to target? thanks.

@cmonr
Copy link
Contributor

cmonr commented Dec 11, 2018

@adbridge Am confused by the statement as well.

The original issue was reported with a single target, but the fix is considerably more generic. Moved to RC3, and will let the eastern hemisphere sort it out.

@tz-arm This PR still needs work. Please take a look at the travis-ci/astyle job output for details. Small whitespace/styling issues were found with the PR.

Copy link
Contributor

@jarvte jarvte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix astyle.

Copy link

@AriParkkila AriParkkila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run:
astyle.exe -n --options=.astylerc features/cellular/framework/AT/AT_CellularStack.cpp

@tz-arm
Copy link
Contributor Author

tz-arm commented Dec 11, 2018

@cmonr @adbridge @AriParkkila, thanks for your comments, I understand where the target confusion come from:
While I see " What target does this relate to" from issue report format, normally I will fill the target I used for testing/reproduce, but not the target I assume it will affect (reporter could not always point out the affect targets correctly), is it possible to make the comments more clear? e.g. reproduce target, affect target

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 11, 2018

The report was fine (reported target that you tested on, the bug was found in the generic layer)

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 11, 2018

Test restarted (failed due to not enough space , fixed now)

@mbed-ci
Copy link

mbed-ci commented Dec 11, 2018

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
  • jenkins-ci/mbed-os-ci_exporter

@cmonr
Copy link
Contributor

cmonr commented Dec 11, 2018

Last CI job somehow got stuck at starting the exporter jobs, even though CI was completely empty.

Restarted jenkins-ci/exporter job.

Because original job was never started, there was nothing to restart. Had to manually fill in job parameters. On success, should make continuous-integration/jenkins/pr-head green as well.

@cmonr cmonr removed the needs: CI label Dec 11, 2018
@cmonr cmonr merged commit 59ac1bb into ARMmbed:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants