Cellular: changed support features to CellularProperty array. #9050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarvte
force-pushed
the
support_feature_to_key_value
branch
from
e560c1c to
0f1e08f
Compare
AriParkkila
approved these changes
Dec 11, 2018
|
@jarvte, thank you for your changes. |
cmonr
approved these changes
Dec 11, 2018
| AT_CellularBase::AT_CGSN_WITH_TYPE, | ||
| AT_CellularBase::SUPPORTED_FEATURE_END_MARK | ||
| static const intptr_t cellular_properties[AT_CellularBase::CELLULAR_PROPERTY_MAX] = { | ||
| 0, // AT_CGSN_WITH_TYPE |
AriParkkila
approved these changes
Dec 12, 2018
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed AT_CellularBase supported features to Cellular properties.
This change enables more properties with different values. More properties coming in different pr.
@AriParkkila please review
Pull request type