Skip to content

NUCLEO_H743ZI: add new platform #9056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 4, 2019
Merged

NUCLEO_H743ZI: add new platform #9056

merged 4 commits into from
Jan 4, 2019

Conversation

bcostm
Copy link
Contributor

@bcostm bcostm commented Dec 11, 2018

Description

Add this new platform:
https://os.mbed.com/platforms/ST-Nucleo-H743ZI/

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from a team December 11, 2018 14:00
@ciarmcom
Copy link
Member

@bcostm, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-tools please review.

jeromecoutant
jeromecoutant reviewed Dec 11, 2018
View reviewed changes
targets/TARGET_STM/lp_ticker.c Outdated
@@ -151,7 +151,7 @@ void lp_ticker_init(void)

NVIC_SetVector(LPTIM1_IRQn, (uint32_t)LPTIM1_IRQHandler);

#if !(TARGET_STM32L4)
#if !(TARGET_STM32L4) && !(TARGET_STM32H7)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be rebased since #8960 merge :-(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Rebased done

@jeromecoutant
Copy link
Collaborator

@seshsubb
@OmerRosler
@peeyushpashine

@bcostm
Copy link
Contributor Author

bcostm commented Dec 11, 2018

Rebased

bridadan
bridadan approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to tooling look good to me (just target.json and iar definitions)

theotherjimmy
theotherjimmy approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tools changes here. approval only good for mbed-os-tools.

@0xc0170 0xc0170 requested a review from ashok-rao December 12, 2018 09:49
@theotherjimmy
Copy link
Contributor

self FYI, #8757 needs to be sure to rebase after this PR goes in, to prevent semantic, but not git, conflicts.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 13, 2018

As soon as @ashok-rao approves, we can start CI here

@cmonr
Copy link
Contributor

cmonr commented Dec 13, 2018

@0xc0170 I also think this should wait until #8757 is in and the PR is rebased before starting CI.

@jeromecoutant
Copy link
Collaborator

#8757 target is 5.12 !
I expect to use NUCLEO_H743ZI before...

ashok-rao
ashok-rao approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@ashok-rao ashok-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I'll let @0xc0170 & team decide about the preceding PR..

@theotherjimmy
Copy link
Contributor

@cmonr That's backwards. Get this in, then #8757 is rebased.

@cmonr cmonr mentioned this pull request Dec 13, 2018
Merged
@cmonr
Copy link
Contributor

cmonr commented Dec 14, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 14, 2018

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@jeromecoutant
Copy link
Collaborator

This fixes #6101

@jeromecoutant jeromecoutant mentioned this pull request Dec 14, 2018
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2018

Yes that was @cmonr earlier proposal. Only export for IAR should be removed, and we can restart CI

@bcostm
Copy link
Contributor Author

bcostm commented Dec 18, 2018

OK. IAR exporter has been removed.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2018

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@cmonr
Copy link
Contributor

cmonr commented Dec 18, 2018

Ticket for adding CMSIS Pack to CI: MBEDOSTEST-398

@cmonr cmonr added the parked label Dec 21, 2018
@cmonr
Copy link
Contributor

cmonr commented Dec 21, 2018

Parking since unless the Node update happens tomorrow, it'll likely be a couple more days until an update is available (holidays).

@cmonr
Copy link
Contributor

cmonr commented Jan 3, 2019

Poked @ARMmbed/mbed-os-test-team again.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 4, 2019

I restarted travis, it should be green (if not, we might need to rebase this to get latest travis config)), and will restart CI right after

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 4, 2019

CI restarted (jenkins is now green)

CMSIS pack should be in place

@bcostm bcostm force-pushed the add_NUCLEO_H743ZI branch from a8d65e2 to b897719 Compare January 4, 2019 09:04
@bcostm
Copy link
Contributor Author

bcostm commented Jan 4, 2019

Rebased

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 4, 2019

OK, restarting CI now (aborting the one I started earlier)

@mbed-ci
Copy link

mbed-ci commented Jan 4, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@mbed-ci
Copy link

mbed-ci commented Jan 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts

@cmonr cmonr merged commit a857e95 into ARMmbed:master Jan 4, 2019
@bcostm bcostm deleted the add_NUCLEO_H743ZI branch January 14, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromecoutant jeromecoutant jeromecoutant left review comments

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@bridadan bridadan bridadan approved these changes

@ashok-rao ashok-rao ashok-rao approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.2 scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bcostm @ciarmcom @jeromecoutant @theotherjimmy @0xc0170 @cmonr @mbed-ci @bridadan @ashok-rao