Create pwmout_api.c

[Willem23]

Added PWM support for the LPC812 using the SCT. Code was ported from LPC824 libs.
First needed to modify us_ticker() to free up the SCT and use the MRT instead.
PWM can support a maximum of 4 channels using any portpin. All channels will use the same period.

[0xc0170]

Isn't this the target which will need modifications to have slave enabled?

[Willem23]

Hi Martin,

As explained in the comments for the pull request, the I2C slave can be
enabled and the slave block read/write operations are fine. The additional
work in I2CSlave.cpp is needed for a correct operation of the slave byte
read/write operations. This change includes platforms such as the LPC812 and
LPC824 because they have different I2C engines for master and slave.

Again, the currently accepted LPC824 I2C slave lib has that same problem and
doesn't work correctly for the slave byte read/writes.

Wim

---

From: Martin Kojtal [mailto:[email protected]]
Sent: donderdag 12 februari 2015 9:32
To: mbedmicro/mbed
Cc: Wim
Subject: Re: [mbed] Create pwmout_api.c (#906)

In libraries/mbed/targets/hal/TARGET_NXP/TARGET_LPC81X/device.h
#906 (comment) :

@@ -29,7 +29,7 @@
#define DEVICE_SERIAL_FC 1

#define DEVICE_I2C 1
-#define DEVICE_I2CSLAVE 0
+#define DEVICE_I2CSLAVE 1

Isn't this the target which will need modifications to have slave enabled?

Reply to this email directly or view it on
https://github.com/mbedmicro/mbed/pull/906/files#r24565131 GitHub.
<https://github.com/notifications/beacon/AKMUNJ5mrGex1x6ADfFng6gpyjnPdGHRks5
nrFyBgaJpZM4DfF7f.gif>

[0xc0170]

Ok, understand.

Why is I2C Slave enabled?

[0xc0170]

I don't want to enable slave for this platform if we know it's not fully functional, as users might struggle in case they use byte oriented approach. That's why I asked why slave is enabled. What do you think?

[Willem23]

Then I propose you also disable the LPC824 I2C stuff since I know it is not
fully functional in several areas. The LPC812 I2C Slave lib as such is
correct. The fixes need to be made to I2CSlave.cpp by calling the correct
slave byte/read operations in LPC812. I proposed a temporary fix in I2CSlave
before by using a macro for the 812. This could be removed as soon as the
other libs are updated to the same level as the LPC812.

Regards

Wim

---

From: Martin Kojtal [mailto:[email protected]]
Sent: donderdag 12 februari 2015 14:22
To: mbedmicro/mbed
Cc: Wim
Subject: Re: [mbed] Create pwmout_api.c (#906)

I don't want to enable slave for this platform if we know it's not fully
functional, as users might struggle in case they use byte oriented approach.

Reply to this email directly or view it
#906 (comment) on
GitHub.
<https://github.com/notifications/beacon/AKMUNFct0M2JCbNf_4S5CVQstFX1qsjgks5
nrKCPgaJpZM4DfF7f.gif>