Skip to content

Fix duplicate 'overrides' keys in targets.json config file #9060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Dec 12, 2018
Merged

Fix duplicate 'overrides' keys in targets.json config file #9060

merged 1 commit into from Dec 12, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 11, 2018

Description

Some target configurations in targets.json contain duplicate key entries, not sure if it actually causes any issues, but it's incorrect.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

cmonr
cmonr approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 12, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 12, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit fda9f2e into ARMmbed:master Dec 12, 2018
@ghost ghost deleted the fix-duplicate-keys-in-targets-json branch December 13, 2018 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-version: 5.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xc0170 @mbed-ci @cmonr