Skip to content

Update to add support for Cortex-M33FD #9097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2018
Merged

Update to add support for Cortex-M33FD #9097

merged 1 commit into from
Dec 17, 2018

Conversation

mmahadevan108
Copy link
Contributor

Description

Update to the toolchain file was missed as part of this below PR
#8995

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@mmahadevan108
Copy link
Contributor Author

cc @cmonr @0xc0170 @theotherjimmy @deepikabhavnani

@cmonr
Copy link
Contributor

cmonr commented Dec 14, 2018

Reference #8992 for more background.

@cmonr cmonr requested a review from a team December 14, 2018 00:23
cmonr
cmonr approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but will wait until someone closer to tools also gives the ok.

@cmonr cmonr requested a review from a team December 14, 2018 00:23
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 14, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 15, 2018

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 17, 2018

License server issue, we will restart the job soon

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 17, 2018

Exporters restarted

@cmonr cmonr merged commit 891427c into ARMmbed:master Dec 17, 2018
@mmahadevan108 mmahadevan108 deleted the Add_CM33FD branch January 17, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@deepikabhavnani deepikabhavnani deepikabhavnani approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mmahadevan108 @cmonr @0xc0170 @mbed-ci @theotherjimmy @deepikabhavnani