Skip to content

Cellular: Non-IP socket and PDP context for EPS control plane data de… #9121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2018
Merged

Cellular: Non-IP socket and PDP context for EPS control plane data de… #9121

merged 1 commit into from
Dec 20, 2018

Conversation

mirelachirica
Copy link
Contributor

…livery

Description

Introducing:

  • CellularNonIPSocket - Non-IP cellular socket to be used for data transfer over a control plane CIoT EPS optimisation connection
  • ControlPlane_netif - Interface that implemets the data delivery over a control plane CIoT EPS optimisation connection, using the standard or target specific AT commands
  • Quectel BG96 support for its specific AT commands dedicated for data delivery over Non-IP control plane(CIoT EPS optimisation) connection

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@mirelachirica
Copy link
Contributor Author

@jarvte and @AriParkkila please review.

@ciarmcom ciarmcom requested review from a team December 17, 2018 12:00
@ciarmcom
Copy link
Member

@mirelachirica, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

jarvte
jarvte suggested changes Dec 18, 2018
View reviewed changes
@mirelachirica mirelachirica force-pushed the feature-cellular-refactor_nonip branch from a71fcff to 456211a Compare December 19, 2018 08:39
@mirelachirica
Copy link
Contributor Author

Teppo's reviews resolved.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 19, 2018

This needs a rebase now as well

@mirelachirica mirelachirica force-pushed the feature-cellular-refactor_nonip branch from 456211a to 8129f78 Compare December 19, 2018 14:49
cmonr
cmonr reviewed Dec 20, 2018
View reviewed changes
features/netsocket/cellular/CellularNonIPSocket.cpp

nsapi_error_t ret = NSAPI_ERROR_OK;
if (!_opened) {
return NSAPI_ERROR_NO_SOCKET;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the lock not need to be unlocked before exiting this function?

@cmonr
Copy link
Contributor

cmonr commented Dec 20, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 20, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 2af12ae into ARMmbed:feature-cellular-refactor Dec 20, 2018
@cmonr cmonr removed the needs: CI label Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@jarvte jarvte jarvte approved these changes

Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mirelachirica @ciarmcom @0xc0170 @cmonr @mbed-ci @jarvte