DNS tests: improve debug messages #9129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmonr
approved these changes
Dec 17, 2018
|
Waiting on #9131 for a fix to Travis CI. |
|
@jeromecoutant While we're waiting on the Travis CI fix and reviews, would you mind fixing the astyle issue? |
jeromecoutant
force-pushed
the
PR_DNSDEBUG
branch
from
f12016b to
bd4b99c
Compare
done |
0xc0170
requested review from
a team
and removed request for
mikaleppanen and
jarlamsa
SeppoTakalo
approved these changes
Dec 18, 2018
0xc0170
approved these changes
Dec 18, 2018
|
CI started |
Test run: SUCCESSSummary: 9 of 9 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Goal is only to update the console log in case of errors.
There is no test change.
Ex before:
mbedgt: :33::FAIL: Expression Evaluated To FALSE
Same error case with this patch:
mbedgt: :33::FAIL: Expected -3004 Was 0
Pull request type