Fix BLE long write execution failure #9143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan-
approved these changes
Dec 19, 2018
There was a problem hiding this comment.
Thanks for the submission @desmond-blue!
Your reasoning is correct; as this implementation doesn't supports "atomic" writes of multiple characteristics; the handle can be retrieved from long_write_request_t::attr_handle.
Could you apply your fix to the NRF51 implementation ? It is here.
desmond-blue
force-pushed
the
fix_ble_longwrite
branch
from
4a3d9bb to
30ca813
Compare
|
@pan- Thanks for reviewing, the change is also applied to NRF51 implementation now. |
pan-
approved these changes
Dec 19, 2018
0xc0170
approved these changes
Dec 19, 2018
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In function nRF5xGattServer::hwCallback(), case BLE_GATTS_OP_EXEC_WRITE_REQ_NOW, the value of variable characteristicIndex is -1 so that causes an exception.
The reason is that the handle_value is retrieved from Execute Write Request, but in spec there is no attribute handle field for this command, I believe this attribute handle should be retrieved from previous Prepare Write Request, in our code, it’s req->attr_handle.
There is one issue (#8548) regarding this fix.
Pull request type