-
Notifications
You must be signed in to change notification settings - Fork 3k
Drop MBED_EXTENTED_TESTS flagging from network tests. #9159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All properly working IP stacks are required to pass Mbed OS socket tests. This have now proven with current Ethernet devices with LwIP stack.
@OPpuolitaival @VeijoPesonen Please review. |
CI started |
@SeppoTakalo I'm going to restart greentea tests a couple of times since this enablement has burned us in the past. Will hold off on merging until @OPpuolitaival or someone from @ARMmbed/mbed-os-test-team gives the OK. |
Fingers crossed that the CI's networking backend takes kindly to this test. |
Test run: SUCCESSSummary: 9 of 9 test jobs passed |
Second run passed just fine. Running once more, and should be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are important for Pelion project. I did check CI and error was not related to this. Restarted the failed board tests
Hi You should then increase the test timeout value now? Ex for DNS test, timeout value is 120
|
@jeromecoutant Please send a PR for longer timeout values. There have originally been set optimistically for Ethernet, so some Cellular devices or external serial driven devices might not pass within the time. |
Description
All properly working IP stacks are required to pass Mbed OS socket tests.
This have now proven with current Ethernet devices with LwIP stack.
Test results: From internal Jenkins when running full set of network tests on Mbed OS:
Pull request type