Skip to content

Drop MBED_EXTENTED_TESTS flagging from network tests. #9159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2018

Conversation

SeppoTakalo
Copy link
Contributor

Description

All properly working IP stacks are required to pass Mbed OS socket tests.
This have now proven with current Ethernet devices with LwIP stack.

Test results: From internal Jenkins when running full set of network tests on Mbed OS:

screenshot 2018-12-19 at 16 19 31

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

All properly working IP stacks are required to pass Mbed OS socket tests.
This have now proven with current Ethernet devices with LwIP stack.
@SeppoTakalo
Copy link
Contributor Author

@OPpuolitaival @VeijoPesonen Please review.

@cmonr
Copy link
Contributor

cmonr commented Dec 19, 2018

CI started

@cmonr
Copy link
Contributor

cmonr commented Dec 19, 2018

@SeppoTakalo I'm going to restart greentea tests a couple of times since this enablement has burned us in the past.

Will hold off on merging until @OPpuolitaival or someone from @ARMmbed/mbed-os-test-team gives the OK.

@cmonr
Copy link
Contributor

cmonr commented Dec 19, 2018

Fingers crossed that the CI's networking backend takes kindly to this test.

@mbed-ci
Copy link

mbed-ci commented Dec 19, 2018

Test run: SUCCESS

Summary: 9 of 9 test jobs passed
Build number : 1
Build artifacts

@cmonr
Copy link
Contributor

cmonr commented Dec 20, 2018

Second run passed just fine. Running once more, and should be good.

Copy link
Contributor

@OPpuolitaival OPpuolitaival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are important for Pelion project. I did check CI and error was not related to this. Restarted the failed board tests

@0xc0170 0xc0170 merged commit aceeb26 into ARMmbed:master Dec 20, 2018
@SeppoTakalo SeppoTakalo deleted the unflag_extented branch December 21, 2018 11:02
@jeromecoutant
Copy link
Collaborator

Hi

You should then increase the test timeout value now?

Ex for DNS test, timeout value is 120

target platform_name test suite result elapsed_time (sec) copy_method
DISCO_L475VG_IOT01A-ARM DISCO_L475VG_IOT01A tests-netsocket-dns OK 123.94 default

@SeppoTakalo
Copy link
Contributor Author

@jeromecoutant Please send a PR for longer timeout values.

There have originally been set optimistically for Ethernet, so some Cellular devices or external serial driven devices might not pass within the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants