Don't use define checks on DEVICE_FOO macros (partner code) #9163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmonr
requested review from
MarceloSalazar,
screamerbg,
ashok-rao and
a team
cmonr
reviewed
Dec 19, 2018
...RGET_STM32F439xI/TARGET_MODULE_UBLOX_ODIN_W2/sdk/ublox-odin-w2-drivers/OdinWiFiInterface.cpp
Show resolved
Hide resolved
|
@MarceloSalazar @screamerbg @ashok-rao Please add any other partners for review if needed. |
TomoYamanaka
approved these changes
Dec 20, 2018
targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF51/TARGET_MCU_NRF51822_UNIFIED/analogin_api.c
Show resolved
Hide resolved
mmahadevan108
approved these changes
Dec 20, 2018
deece
force-pushed
the
fix-8913-partner
branch
from
cc46d70 to
f94ffcd
Compare
bcostm
suggested changes
Dec 20, 2018
The DEVICE_FOO macros are always defined (either 0 or 1). This patch replaces any instances of a define check on a DEVICE_FOO macro with value test instead. Signed-off-by: Alastair D'Silva <[email protected]>
deece
force-pushed
the
fix-8913-partner
branch
from
f94ffcd to
aa80b7c
Compare
0xc0170
approved these changes
Dec 20, 2018
bcostm
approved these changes
Dec 20, 2018
|
We would like to proceed with this PR after this week, please review |
stevew817
approved these changes
Jan 2, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Will wait until beginning of next week to merge, to give additional partners time to review/ok. |
|
Time to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #8957 (partner components).
The DEVICE_FOO macros are predefined to be 0 or 1. There are a number of instances which incorrectly check if they are defined, rather than checking the value.
This PR addresses most (if not all) of these incorrect checks.
Fixes #8913
Pull request type