-
Notifications
You must be signed in to change notification settings - Fork 3k
MTB_ODIN_v2_fixes #9174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTB_ODIN_v2_fixes #9174
Conversation
Can you add the list from description to the commit msg ? v2.0.0 - what for users with older revision, or only 2.0.0 out there? |
Thanks @0xc0170 .. only v2.0.0 going out.. earlier version was for internal development only.. |
IF you can extend the commit message to contain details that are provided here, we will start CI |
@ashok-rao, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve the commit message as requested above
@ashok-rao If there are any tests that run LSE_Clock, would be good to check that those are no logner run. Otherwise, I'm not sure which tests would test the SPI pins. |
1. Removed redundant code comments. Added relevant ones for MTB pins. 2. More SPI_CS pins added for peripherals on the MTB. 3. Disabled LSE_Clock as it is not present on the MTB in targets.json
@0xc0170 : Force pushed with changes to commit message :-) |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Fixes to MTB_ODIN target based on v2.0.0 of the MCB hardware:
@0xc0170 , @cmonr : Could you please let me know what test results I need to attach for this PR? I've tested a basic blinky that tests the SPI (LCD), I2C (temp sensor) and PWMs (LEDs) on the MTB & it is working fine. Thanks.
Pull request type
Reviewers
@cmonr @0xc0170 : Could you please review? Thanks.