Greentea tests ignore bind returning UNSUPPORTED #9175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeppoTakalo
reviewed
Dec 20, 2018
SeppoTakalo
approved these changes
Dec 20, 2018
0xc0170
approved these changes
Jan 2, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 9 test jobs failed Failed test jobs:
|
|
Test restarted |
|
merge please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Greentea tests should not fail if the stack doesn't support bind(). Instead some tests should be ignored.
I tested this by running the whole udp and tcp suites (including extended tests) with LWIP stack and then again with LWIP stack hacked to always return NSAPI_ERROR_UNSUPPORTED from socket_bind.
I also checked tests-netsocket-dns with this "hacked" LWIP but it never failed, so no adjustments are needed.
Pull request type
Reviewers
@SeppoTakalo
@VeijoPesonen
@KariHaapalehto