Skip to content

Resolves build failures with IAR 8.x #9187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 2, 2019

Conversation

deepikabhavnani
Copy link

Description

Individual build commits describe more of build failures.
Local IAR Version 8.32
Target K64F

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Deepika added 3 commits December 21, 2018 13:28
Space needed between 2 string literals
    [Error] fopen.cpp@204,97: [Pe2486]: user-defined literal operator not found
`size` is part of std library since c++17, and results in build
errors for IAR 8.x.
https://en.cppreference.com/w/cpp/iterator/size
@ciarmcom
Copy link
Member

@deepikabhavnani, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team December 21, 2018 22:00
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the informative commits!

@dannybenor
Copy link

@theamirocohen please review

@theamirocohen
Copy link
Contributor

LGTM

@NirSonnenschein
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 31, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@NirSonnenschein
Copy link
Contributor

There are reviews by @cmonr and @theamirocohen and CI passed so this should be ready.

Copy link
Contributor

@theamirocohen theamirocohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants