Add more information to error url to enhance error analytics #9188
Conversation
| @@ -108,11 +108,6 @@ | |||
| "value": null | |||
| }, | |||
|
|
|||
| "error-decode-http-url-str": { | |||
There was a problem hiding this comment.
I removed this config as its used only in one place. So I'm just hard-coding for now.
There was a problem hiding this comment.
That's fine, but because this is a config removal, this change would cause it to be bumped to 5.12.
Will assume that is the intention for now, unless this change is reverted to remain.
| @@ -201,6 +201,8 @@ def get_symbols(self, for_asm=False): | |||
| if MBED_ORG_USER: | |||
| self.cxx_symbols.append('MBED_USERNAME=' + MBED_ORG_USER) | |||
|
|
|||
| # Add target's name | |||
| self.cxx_symbols += ["TARGET_NAME=" + self.target.name] | |||
There was a problem hiding this comment.
Interesting. I thought this information would have already been available elsehwere.
There was a problem hiding this comment.
@theotherjimmy @bridadan Making sure before I press the button. Is this symbol not already available in the build system?
There was a problem hiding this comment.
Sorry a bit late to review this. To my knowledge this symbol wasn't already present. The only that was present were symbols like TARGET_<target name>.
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
tools/toolchains/__init__.py
Outdated
| @@ -191,7 +191,7 @@ def get_symbols(self, for_asm=False): | |||
| labels = self.get_labels() | |||
| self.cxx_symbols = ["TARGET_%s" % t for t in labels['TARGET']] | |||
| self.cxx_symbols.extend(["TOOLCHAIN_%s" % t for t in labels['TOOLCHAIN']]) | |||
|
|
|||
There was a problem hiding this comment.
this empty space should be removed (how come astyle did not catch that)
There was a problem hiding this comment.
@0xc0170 Congrats on the new test case!
SenRamakri
force-pushed
the
sen_ErrorUrlEnhance
branch
from
7ad9fe9 to
3e6dafa
Compare
|
CI started |
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
|
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
This change adds more info to the error URL in error-report to enable additional analytics in https://mbed.com/s/error. It adds following info to the error URL:
CPU id (if stats enabled)
Compiler used (if stats enabled)
Compiler version (if stats enabled)
MbedOS version (if stats enabled)
Target name
Pull request type
Reviewers