-
Notifications
You must be signed in to change notification settings - Fork 3k
Nuvoton: Fix UART flow control CTS/RTS #9197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuvoton: Fix UART flow control CTS/RTS #9197
Conversation
Configure RTS pin outout to active low when RTS is disabled. This allows the peer to be able to send data if its CTS is still enabled.
@ccli8, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waaait. Asking a question.
Is there something amis with the way Nuvoton's hw flow control works that it needs a software bypass? I'm not sure why this fix is needed. |
@cmonr There're two reasons for this change:
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
This PR tries to enhance the case in which RTS pin output would drive to low when RTS is disabled. This allows the peer to be able to send data even though its corresponding CTS is still enabled.
Related targets
Pull request type