Skip to content

Add Dynamic heap support to IAR #9205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Dynamic heap support to IAR #9205

wants to merge 1 commit into from

Conversation

deepikabhavnani
Copy link

Description

feature-iar8 is rebased on top of master. This PR is for IAR dynamic heap changes in new linker files.

PR should be tested with CI first - Please note new addition to linker script will result in failures with IAR 7.x
feature-iar8 needs to be tested with IAR 8.32 version - Update needed in CI

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested a review from a team December 27, 2018 18:00
@ciarmcom
Copy link
Member

@deepikabhavnani, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@cmonr cmonr added the parked label Dec 27, 2018
@cmonr
Copy link
Contributor

cmonr commented Dec 27, 2018

Update needed in CI

@ARMmbed/mbed-os-test-team This will need IAR 8 in CI before it can progress.

@cmonr cmonr requested a review from a team December 27, 2018 20:11
@deepikabhavnani deepikabhavnani mentioned this pull request Jan 7, 2019
Closed
@deepikabhavnani
Copy link
Author

Rebased

@cmonr
Copy link
Contributor

cmonr commented Jan 11, 2019 •
edited
Loading

Wrong PR...

Add Dynamic heap support to IAR
b88b0b5 
Two new block properties available in linker configuration files:
"expanding size" and "minimum size" for IAR 8.11.2 and above

Sample:
define block HEAP with expanding size, minimum size = 16K, alignment = 8 {};

This block will expand to consume all remaining available space in
the range where it is placed. If several such blocks end up in the same
range, they will share the remaining space.
Cannot place a block with expanding size inside another block with
expanding size, inside a block with maximum size, or inside an overlay.
@deepikabhavnani
Copy link
Author

Rebased feature-iar8 and this PR

@cmonr cmonr removed the parked label Jan 18, 2019
@cmonr
Copy link
Contributor

cmonr commented Jan 28, 2019

@deepikabhavnani Does this still need a CI config change, or is waiting for a review?

@deepikabhavnani
Copy link
Author

@deepikabhavnani Does this still need a CI config change, or is waiting for a review?

We need IAR 8.32 for feature branch in CI, not sure if it is ready now?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 29, 2019

I'll find out today about the feature branches and compiler versions

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 29, 2019

Testing it :-)

@mbed-ci
Copy link

mbed-ci commented Jan 29, 2019

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@deepikabhavnani
Copy link
Author

deepikabhavnani commented Jan 29, 2019 •
edited
Loading

We need IAR 8.32 for feature branch in CI, not sure if it is ready now?
Testing it :-)

This PR build will fail with IAR 7.x because of linker file changes, as per build log IAR version was 7.80.1.28


[ARM_BEETLE_SOC:IAR]         [DEBUG] Output:    IAR ELF Linker V7.80.1.28/LNX for ARM
[ARM_BEETLE_SOC:IAR]         [DEBUG] Output:    Copyright 2007-2016 IAR Systems AB.
[ARM_BEETLE_SOC:IAR]         [DEBUG] Output: 
[ARM_BEETLE_SOC:IAR]         [DEBUG] Output: Errors: 1
[ARM_BEETLE_SOC:IAR]         [DEBUG] Output: Warnings: none
[ARM_BEETLE_SOC:IAR]         [DEBUG] Output: 
[ARM_BEETLE_SOC:IAR]         [DEBUG] Output: Link time:   0.00 (CPU)   0.00 (elapsed)
[ARM_BEETLE_SOC:IAR]         [DEBUG] Errors: 
[ARM_BEETLE_SOC:IAR]         [DEBUG] Errors:   define block HEAP      with expanding size, minimum size = __

@deepikabhavnani
Copy link
Author

We need IAR 8.32 for feature branch in CI, not sure if it is ready now?
Testing it :-)
This PR build will fail with IAR 7.x because of linker file changes, as per build log IAR version was 7.80.1.28

Testing now for IAR 8.x - CI started

@deepikabhavnani
Copy link
Author

Stil on IAR7 - will close this PR and open new one

@deepikabhavnani deepikabhavnani deleted the update_linker_files branch February 6, 2019 18:12
@kjbracey kjbracey mentioned this pull request Jul 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deepikabhavnani @ciarmcom @cmonr @0xc0170 @mbed-ci @adbridge