Skip to content

Change to mbedtls_platform_zeroize() #9218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

RonEld
Copy link
Contributor

@RonEld RonEld commented Jan 1, 2019

Description

Change the use of the local static function mbedtls_zeroize() to
the Mbed TLS platform function mbedtls_platform_zeroize(), since this platform function was introduced after the Cryptocell 310 adaptation driver was introduced.

Pull request type

[ ] Fix
[ ] Refactor
[ x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-crypto

Change the use of the local static function `mbedtls_zeroize()` to
the Mbed TLS platform function `mbedtls_platform_zeroize()`.
@ciarmcom ciarmcom requested review from a team January 1, 2019 12:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 1, 2019

@RonEld, thank you for your changes.
@ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 2, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 2, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 2, 2019

Test restarted (one of the boards failed to even start)

@cmonr
Copy link
Contributor

cmonr commented Jan 2, 2019

Will need to restart once CI issue is resolved.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 3, 2019

CI restarted

@cmonr cmonr merged commit f9e840e into ARMmbed:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants