Skip to content

Update PSA binaries importer for FUTURE_SEQUANA_PSA #9223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 24, 2019
Merged

Update PSA binaries importer for FUTURE_SEQUANA_PSA #9223

merged 4 commits into from
Jan 24, 2019

Conversation

orenc17
Copy link
Contributor

@orenc17 orenc17 commented Jan 2, 2019

Description

Update PSA binaries importer for FUTURE_SEQUANA_PSA

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@alzix

@ciarmcom ciarmcom requested review from alzix and a team January 2, 2019 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 2, 2019

@orenc17, thank you for your changes.
@alzix @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously requested changes Jan 2, 2019
View reviewed changes
@cmonr cmonr dismissed 0xc0170’s stale review January 3, 2019 03:01

Locense header added. Please re-review.

@cmonr
Copy link
Contributor

cmonr commented Jan 4, 2019

Waiting on @alzix before starting CI

@cmonr cmonr requested a review from danny4478 January 9, 2019 19:55
@cmonr
Copy link
Contributor

cmonr commented Jan 9, 2019

@alzix @danny4478 Would y'all mind reviewing?

danny4478
danny4478 suggested changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@danny4478 danny4478 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need someone who is more familiar with python to finalize this review.
@alzix

@NirSonnenschein
Copy link
Contributor

Issues resolved, starting CI

@mbed-ci
Copy link

mbed-ci commented Jan 24, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr
Copy link
Contributor

cmonr commented Jan 24, 2019

e1af45b

AH. I was wondering why this looked like it still needed CI.

@cmonr
Copy link
Contributor

cmonr commented Jan 24, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 24, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit eb26d82 into ARMmbed:master Jan 24, 2019
@cmonr cmonr removed the needs: CI label Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danny4478 danny4478 danny4478 requested changes

@alzix alzix alzix approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@orenc17 @ciarmcom @cmonr @NirSonnenschein @mbed-ci @alzix @0xc0170 @danny4478