Skip to content

Cellular: Unit tests for Non-IP socket #9226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2019
Merged

Cellular: Unit tests for Non-IP socket #9226

merged 1 commit into from
Jan 7, 2019

Conversation

mirelachirica
Copy link
Contributor

Description

  • Added unit tests for CellularNonIPSocket
  • Changed from public to protected the current control plane netif routines since they should be limited to be used only by sockets(similar to network stack's socket routines)
  • Astyle fixes

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@mirelachirica
Copy link
Contributor Author

@jarvte and @AnttiKauppila could you please review

@ciarmcom ciarmcom requested review from a team January 3, 2019 08:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 3, 2019

@mirelachirica, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team January 3, 2019 08:00
0xc0170
0xc0170 reviewed Jan 3, 2019
View reviewed changes
0xc0170
0xc0170 reviewed Jan 3, 2019
View reviewed changes
@mirelachirica mirelachirica force-pushed the feature-cellular-refactor_nonip_ut branch from a0e5c82 to 6533e19 Compare January 4, 2019 06:47
@cmonr
Copy link
Contributor

cmonr commented Jan 4, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 7, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 7, 2019

We are experiencing CI node failures, few jobs were aborted. We are investigating, will restart the jobs once fixed.

cc @ARMmbed/mbed-os-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 7, 2019

Ci restarted

@mbed-ci
Copy link

mbed-ci commented Jan 7, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 6b0639d into ARMmbed:feature-cellular-refactor Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 left review comments

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mirelachirica @ciarmcom @cmonr @mbed-ci @0xc0170 @SeppoTakalo @AnttiKauppila