Skip to content

TDBStore: fix bug in sector blank check for variant sized sectors #9241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2019
Merged

TDBStore: fix bug in sector blank check for variant sized sectors #9241

merged 1 commit into from
Jan 8, 2019

Conversation

davidsaada
Copy link
Contributor

Description

TDBStore performs erase unit (sector) blank checking before writing new data. This blank check works differently for boards having uniform sector map (all having the same size) and variant ones. This check had a bug in the variant case (reverse condition). Fixed now.

Tested on NUCLEO_F429ZI.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom ciarmcom requested review from a team January 3, 2019 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 3, 2019

@davidsaada, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@theamirocohen theamirocohen mentioned this pull request Jan 7, 2019
Merged
theamirocohen
theamirocohen approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@theamirocohen theamirocohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 7, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 7, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 42fee45 into ARMmbed:master Jan 8, 2019
@davidsaada davidsaada deleted the david_tdbstore_variant_erase_unit_fix branch January 14, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@theamirocohen theamirocohen theamirocohen approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidsaada @ciarmcom @0xc0170 @mbed-ci @theamirocohen